Skip to content

Commit cef1cf2

Browse files
swiftStdlibCollectionUnittest needed by check-swift-validation-only_executable-freestanding-x86_64 and no known rule to make it
Missed some dependencies of the private stdlib pieces that are only available when the SDK overlay is available. rdar://135878323
1 parent 626e511 commit cef1cf2

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

test/CMakeLists.txt

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -333,9 +333,17 @@ foreach(SDK ${SWIFT_SDKS})
333333
list(APPEND test_dependencies "touch-covering-tests")
334334
endif()
335335

336-
list(APPEND test_dependencies
337-
"swiftStdlibCollectionUnittest-${SWIFT_SDK_${SDK}_LIB_SUBDIR}"
338-
"swiftStdlibUnicodeUnittest-${SWIFT_SDK_${SDK}_LIB_SUBDIR}")
336+
# Keep in sync with stdlib/private/CMakeLists.txt: the private stdlib
337+
# targets all rely on the SDK overlay being available.
338+
if(SWIFT_BUILD_SDK_OVERLAY
339+
OR (SWIFT_BUILD_TEST_SUPPORT_MODULES
340+
AND NOT SWIFT_BUILD_DYNAMIC_SDK_OVERLAY_default
341+
AND (SWIFT_ENABLE_REFLECTION
342+
OR NOT SWIFT_HOST_VARIANT_SDK IN_LIST SWIFT_DARWIN_PLATFORMS)))
343+
list(APPEND test_dependencies
344+
"swiftStdlibCollectionUnittest-${SWIFT_SDK_${SDK}_LIB_SUBDIR}"
345+
"swiftStdlibUnicodeUnittest-${SWIFT_SDK_${SDK}_LIB_SUBDIR}")
346+
endir()
339347

340348
set(validation_test_dependencies)
341349

0 commit comments

Comments
 (0)