Merge pull request #38139 from hamishknight/null-check

Author: hamishknight

lib/IDE/Refactoring.cpp

@@ -4536,7 +4536,8 @@ struct CallbackCondition {
 
   /// A bool condition expression.
   explicit CallbackCondition(const Expr *E) {
-    if (!E->getType()->isBool())
+    // FIXME: Sema should produce ErrorType.
+    if (!E->getType() || !E->getType()->isBool())
       return;
 
     auto CondType = ConditionType::IS_TRUE;

test/refactoring/ConvertAsync/convert_invalid.swift

@@ -0,0 +1,14 @@
+func callbackIntWithError(_ completion: (Int8, Error?) -> Void) {}
+
+// rdar://79864182
+// RUN: %refactor -convert-call-to-async-alternative -dump-text -source-filename %s -pos=%(line+1):1 | %FileCheck -check-prefix=INVALID-COND %s
+callbackIntWithError { x, err in
+  if x {
+    print("ok")
+  }
+}
+// INVALID-COND:      let x = try await callbackIntWithError()
+// INVALID-COND-NEXT: if x {
+// INVALID-COND-NEXT:   print("ok")
+// INVALID-COND-NEXT: }
+