Skip to content

Commit d09bf98

Browse files
committed
Update test
1 parent cc3ca1c commit d09bf98

File tree

4 files changed

+8
-7
lines changed

4 files changed

+8
-7
lines changed

lib/SIL/Verifier/SILVerifier.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2451,7 +2451,7 @@ class SILVerifier : public SILVerifierBase<SILVerifier> {
24512451
// from a fragile function is an error.
24522452
if (!F.isNotSerialized()) {
24532453
require((SingleFunction && RefF->isExternalDeclaration()) ||
2454-
RefF->hasValidLinkageForFragileRef(),
2454+
RefF->hasValidLinkageForFragileRef(F.getSerializedKind()),
24552455
"function_ref inside fragile function cannot "
24562456
"reference a private or hidden symbol");
24572457
}

lib/SILOptimizer/IPO/CrossModuleOptimization.cpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,8 @@ bool CrossModuleOptimization::canSerializeFunction(
319319
return false;
320320
}
321321

322-
if (isSerializedWithRightKind(M, function)) {
322+
if (function->isSerialized() ||
323+
isSerializedWithRightKind(M, function)) {
323324
canSerializeFlags[function] = true;
324325
return true;
325326
}
@@ -616,6 +617,8 @@ void CrossModuleOptimization::serializeFunction(SILFunction *function,
616617
if (function->isSerialized())
617618
return;
618619

620+
// If not, check whether it was serialized with
621+
// this optimization.
619622
if (isSerializedWithRightKind(M, function))
620623
return;
621624

test/SILOptimizer/package-cmo-resilient-mode.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@
3030
// RUN: %target-build-swift -module-name=Main -package-name Pkg -I%t -emit-sil -O %t/main.swift -o %t/Main-non-res.sil
3131
// RUN: %FileCheck %s --check-prefixes=CHECK-MAIN-COMMON,CHECK-MAIN-NONRES < %t/Main-non-res.sil
3232

33-
// FIXME: temp disable this test; re-enable
34-
// REQUIRES: rdar999888777
3533
// REQUIRES: swift_in_compiler
3634

3735
//--- main.swift

test/SILOptimizer/package-cmo-serialize-tables.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -505,7 +505,7 @@ package func runPkg(_ arg: [any PkgProto]) {
505505
print(arg)
506506
}
507507

508-
//CHECK-LABEL: sil_vtable [serialized_for_package] ParentPubKlass {
508+
//CHECK-LABEL: sil_vtable [serialized] ParentPubKlass {
509509
//CHECK-NEXT: #ParentPubKlass.parentPubVar!getter: (ParentPubKlass) -> () -> Int : @$s3Lib14ParentPubKlassC06parentC3VarSivg
510510
//CHECK-NEXT: #ParentPubKlass.parentPubVar!setter: (ParentPubKlass) -> (Int) -> () : @$s3Lib14ParentPubKlassC06parentC3VarSivs
511511
//CHECK-NEXT: #ParentPubKlass.parentPubVar!modify: (ParentPubKlass) -> () -> () : @$s3Lib14ParentPubKlassC06parentC3VarSivM
@@ -526,7 +526,7 @@ package func runPkg(_ arg: [any PkgProto]) {
526526
//CHECK-NEXT: #PubKlass.pubFunc: (PubKlass) -> () -> () : @$s3Lib8PubKlassC7pubFuncyyF
527527
//CHECK-NEXT: #PubKlass.deinit!deallocator: @$s3Lib8PubKlassCfD
528528

529-
//CHECK-LABEL: sil_vtable [serialized_for_package] ParentPubKlassWithInternalMemberX {
529+
//CHECK-LABEL: sil_vtable [serialized] ParentPubKlassWithInternalMemberX {
530530
//CHECK-NEXT: #ParentPubKlassWithInternalMemberX.parentPubVar!getter: (ParentPubKlassWithInternalMemberX) -> () -> Int : @$s3Lib33ParentPubKlassWithInternalMemberXC06parentC3VarSivg
531531
//CHECK-NEXT: #ParentPubKlassWithInternalMemberX.parentPubVar!setter: (ParentPubKlassWithInternalMemberX) -> (Int) -> () : @$s3Lib33ParentPubKlassWithInternalMemberXC06parentC3VarSivs
532532
//CHECK-NEXT: #ParentPubKlassWithInternalMemberX.parentPubVar!modify: (ParentPubKlassWithInternalMemberX) -> () -> () : @$s3Lib33ParentPubKlassWithInternalMemberXC06parentC3VarSivM
@@ -549,7 +549,7 @@ package func runPkg(_ arg: [any PkgProto]) {
549549
//CHECK-NEXT: #PubKlassX.pubFunc: (PubKlassX) -> () -> () : @$s3Lib9PubKlassXC7pubFuncyyF
550550
//CHECK-NEXT: #PubKlassX.deinit!deallocator: @$s3Lib9PubKlassXCfD
551551

552-
//CHECK-LABEL: sil_vtable [serialized_for_package] ParentPubKlassWithInternalMemberY {
552+
//CHECK-LABEL: sil_vtable [serialized] ParentPubKlassWithInternalMemberY {
553553
//CHECK-NEXT: #ParentPubKlassWithInternalMemberY.init!allocator: (ParentPubKlassWithInternalMemberY.Type) -> (Int) -> ParentPubKlassWithInternalMemberY : @$s3Lib33ParentPubKlassWithInternalMemberYCyACSicfC
554554
//CHECK-NEXT: #ParentPubKlassWithInternalMemberY.deinit!deallocator: @$s3Lib33ParentPubKlassWithInternalMemberYCfD
555555

0 commit comments

Comments
 (0)