Skip to content

Commit d236577

Browse files
authored
Merge pull request #7593 from hughbe/win-overlay
Fix Windows build docs for the SDK overlay
2 parents 11c9fc0 + 807223f commit d236577

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

docs/Windows.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ cmake -G "Ninja" "%swift_source_dir%/swift"^
129129
-DICU_I18N_LIB_NAME="icuin"^
130130
-DSWIFT_INCLUDE_DOCS=FALSE^
131131
-DSWIFT_INCLUDE_TESTS=FALSE^
132-
-DSWIFT_BUILD_SDK_OVERLAY=FALSE^
132+
-DSWIFT_BUILD_DYNAMIC_SDK_OVERLAY=FALSE^
133133
-DSWIFT_BUILD_RUNTIME_WITH_HOST_COMPILER=FALSE
134134
popd
135135
cmake --build "%swift_source_dir%/build/Ninja-DebugAssert/swift-windows-amd64/ninja"
@@ -144,7 +144,7 @@ cmake -G "Visual Studio 14" "%swift_source_dir%/swift"^
144144

145145
## Clang-cl
146146

147-
Follow the instructions for MSVC, but add the following lines to each CMake configuration command. We need to use LLVM's `lld-link.exe` linker, as MSVC's `link.exe` crashes due to corrupt PDB files using `clang-cl`. `Clang-cl` 3.9.0 has been tested.
147+
Follow the instructions for MSVC, but add the following lines to each CMake configuration command. We need to use LLVM's `lld-link.exe` linker, as MSVC's `link.exe` crashes due to corrupt PDB files using `clang-cl`. `Clang-cl` 3.9.0 has been tested. You can remove the `SWIFT_BUILD_DYNAMIC_SDK_OVERLAY=FALSE` definition, as overlays are supported with `clang-cl`, as it supports modules.
148148

149149
```
150150
-DCMAKE_C_COMPILER="<path-to-llvm-bin>/clang-cl.exe"^

0 commit comments

Comments
 (0)