[DNM] Enable lifetime completion.

Author: nate-chandler

include/swift/AST/SILOptions.h

@@ -183,7 +183,7 @@ class SILOptions {
   bool EnableSILOpaqueValues = false;
 
   /// Require linear OSSA lifetimes after SILGen
-  bool OSSACompleteLifetimes = false;
+  bool OSSACompleteLifetimes = true;
 
   /// Verify linear OSSA lifetimes after SILGen
   bool OSSAVerifyComplete = false;

lib/DriverTool/sil_opt_main.cpp

@@ -231,7 +231,7 @@ struct SILOptOptions {
                         llvm::cl::desc("Compile the module with sil-opaque-values enabled."));
 
   llvm::cl::opt<bool>
-  EnableOSSACompleteLifetimes = llvm::cl::opt<bool>("enable-ossa-complete-lifetimes",
+  EnableOSSACompleteLifetimes = llvm::cl::opt<bool>("enable-ossa-complete-lifetimes", llvm::cl::init(true),
                         llvm::cl::desc("Require linear OSSA lifetimes after SILGenCleanup."));
   llvm::cl::opt<bool>
   EnableOSSAVerifyComplete = llvm::cl::opt<bool>("enable-ossa-verify-complete",

test/AutoDiff/SILOptimizer/activity_analysis.swift

@@ -804,7 +804,7 @@ func testActiveOptional(_ x: Float) -> Float {
 // CHECK: [NONE]   // function_ref _diagnoseUnexpectedNilOptional(_filenameStart:_filenameLength:_filenameIsASCII:_line:_isImplicitUnwrap:)
 // CHECK: [NONE]   %24 = apply %23(%17, %18, %19, %20, %22) : $@convention(thin) (Builtin.RawPointer, Builtin.Word, Builtin.Int1, Builtin.Word, Builtin.Int1) -> ()
 // CHECK: bb2:
-// CHECK: [ACTIVE] %26 = argument of bb2 : $Float
+// CHECK: [ACTIVE] %27 = argument of bb2 : $Float
 
 enum DirectEnum: Differentiable & AdditiveArithmetic {
   case case0

test/SILGen/rethrows.swift

@@ -64,6 +64,8 @@ func test1() throws {
 // CHECK-NEXT:  [[RESULT:%.*]] = tuple ()
 // CHECK-NEXT:  return [[RESULT]]
 // CHECK:     [[ERROR]]([[T0:%.*]] : $any Error):
+// CHECK-NEXT:  strong_release [[T1]]
+// CHECK-NEXT:  strong_release [[T0]]
 // CHECK-NEXT:  unreachable
 func test2() {
   rethrower(nonthrower)
@@ -78,6 +80,7 @@ func test2() {
 // CHECK-NEXT:  [[RESULT:%.*]] = tuple ()
 // CHECK-NEXT:  return [[RESULT]]
 // CHECK:     [[ERROR]]([[ERROR:%.*]] : $any Error):
+// CHECK-NEXT:  strong_release [[ERROR]]
 // CHECK-NEXT:  unreachable
 // CHECK-LABEL: // end sil function '$s8rethrows5test3yyF'
 func test3() {