cleanup: remove unrecognized clang ide diagnostic options

ktoso · ktoso · commit d24f0865f054 · 2024-05-29T17:53:17.000+09:00
These are something CLion understands and suggests, but yeah let's avoid
having warnings in the build.
diff --git a/stdlib/public/Concurrency/Actor.cpp b/stdlib/public/Concurrency/Actor.cpp
@@ -357,8 +357,6 @@ const char *__swift_runtime_env_useLegacyNonCrashingExecutorChecks() {
 #endif
 }
 
-#pragma clang diagnostic push
-#pragma ide diagnostic ignored "ConstantConditionsOC"
 // Done this way because of the interaction with the initial value of
 // 'unexpectedExecutorLogLevel'
 bool swift_bincompat_useLegacyNonCrashingExecutorChecks() {
@@ -378,7 +376,6 @@ bool swift_bincompat_useLegacyNonCrashingExecutorChecks() {
 
   return legacyMode;
 }
-#pragma clang diagnostic pop
 
 // Check override of executor checking mode.
 static void checkIsCurrentExecutorMode(void *context) {

Original file line number	Diff line number	Diff line change
`@@ -357,8 +357,6 @@ const char *__swift_runtime_env_useLegacyNonCrashingExecutorChecks() {`
`357`	`357`	`#endif`
`358`	`358`	`}`
`359`	`359`
`360`		`-#pragma clang diagnostic push`
`361`		`-#pragma ide diagnostic ignored "ConstantConditionsOC"`
`362`	`360`	`// Done this way because of the interaction with the initial value of`
`363`	`361`	`// 'unexpectedExecutorLogLevel'`
`364`	`362`	`bool swift_bincompat_useLegacyNonCrashingExecutorChecks() {`
`@@ -378,7 +376,6 @@ bool swift_bincompat_useLegacyNonCrashingExecutorChecks() {`
`378`	`376`
`379`	`377`	`return legacyMode;`
`380`	`378`	`}`
`381`		`-#pragma clang diagnostic pop`
`382`	`379`
`383`	`380`	`// Check override of executor checking mode.`
`384`	`381`	`static void checkIsCurrentExecutorMode(void *context) {`