Skip to content

Commit d515078

Browse files
committed
[build-script] Several PEP8 fixes.
1 parent bb9fc67 commit d515078

File tree

2 files changed

+13
-11
lines changed

2 files changed

+13
-11
lines changed

utils/build-script

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -114,10 +114,10 @@ class HostSpecificConfiguration(object):
114114
continue
115115

116116
# Compute which actions are desired.
117-
build = deployment_platform not in \
118-
invocation.platforms_to_skip_build
119-
test = deployment_platform not in \
120-
invocation.platforms_to_skip_test
117+
build = (
118+
deployment_platform not in invocation.platforms_to_skip_build)
119+
test = (
120+
deployment_platform not in invocation.platforms_to_skip_test)
121121
test_host_only = None
122122
build_benchmark = build and deployment_target.supports_benchmark
123123
# FIXME: Note, `build-script-impl` computed a property here
@@ -448,7 +448,8 @@ class BuildScriptInvocation(object):
448448
if args.skip_test_ios_host:
449449
self.platforms_to_skip_test.add(StdlibDeploymentTarget.iOS)
450450
if args.skip_test_ios_simulator:
451-
self.platforms_to_skip_test.add(StdlibDeploymentTarget.iOSSimulator)
451+
self.platforms_to_skip_test.add(
452+
StdlibDeploymentTarget.iOSSimulator)
452453
if args.skip_test_tvos_host:
453454
self.platforms_to_skip_test.add(StdlibDeploymentTarget.AppleTV)
454455
if args.skip_test_tvos_simulator:
@@ -469,7 +470,8 @@ class BuildScriptInvocation(object):
469470
if args.skip_test_ios_host:
470471
self.platforms_to_skip_test_host.add(StdlibDeploymentTarget.iOS)
471472
if args.skip_test_tvos_host:
472-
self.platforms_to_skip_test_host.add(StdlibDeploymentTarget.AppleTV)
473+
self.platforms_to_skip_test_host.add(
474+
StdlibDeploymentTarget.AppleTV)
473475
if args.skip_test_watchos_host:
474476
self.platforms_to_skip_test_host.add(
475477
StdlibDeploymentTarget.AppleWatch)
@@ -752,12 +754,12 @@ class BuildScriptInvocation(object):
752754
args = self.args
753755

754756
options = {}
755-
for host in [args.host_target] + args.cross_compile_hosts:
757+
for host_target in [args.host_target] + args.cross_compile_hosts:
756758
# Compute the host specific configuration.
757-
config = HostSpecificConfiguration(host, self)
759+
config = HostSpecificConfiguration(host_target, self)
758760

759761
# Convert into `build-script-impl` style variables.
760-
options[host] = {
762+
options[host_target] = {
761763
"SWIFT_SDKS": " ".join(sorted(
762764
config.sdks_to_configure)),
763765
"SWIFT_STDLIB_TARGETS": " ".join(
@@ -1794,7 +1796,7 @@ details of the setups of other systems or automated environments.""")
17941796
invocation.build_ninja()
17951797

17961798
# Convert to a build-script-impl invocation.
1797-
(build_script_impl_env,build_script_impl_args) = \
1799+
(build_script_impl_env, build_script_impl_args) = \
17981800
invocation.convert_to_impl_arguments()
17991801

18001802
# Execute the underlying build script implementation.

utils/swift_build_support/swift_build_support/targets.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ class DarwinPlatform(Platform):
4747
def __init__(self, name, archs, sdk_name=None, is_simulator=False):
4848
super(DarwinPlatform, self).__init__(name, archs, sdk_name)
4949
self.is_simulator = is_simulator
50-
50+
5151
@property
5252
def is_embedded(self):
5353
"""Check if this is a Darwin platform for embedded devices."""

0 commit comments

Comments
 (0)