Skip to content

Commit d591be0

Browse files
committed
utils: require a fully qualified WinSDK version
Do not attempt to complete the version number, instead require the user to fully specify the version, e.g. 10.0.26000.0.
1 parent 0d8e005 commit d591be0

File tree

1 file changed

+9
-12
lines changed

1 file changed

+9
-12
lines changed

utils/build.ps1

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -199,9 +199,6 @@ if ($PinnedBuild -eq "") {
199199
}
200200
}
201201

202-
# Store the revision zero variant of the Windows SDK version (no-op if unspecified)
203-
$WindowsSDKMajorMinorBuildMatch = [Regex]::Match($WinSDKVersion, "^\d+\.\d+\.\d+")
204-
$WinSDKVersionRevisionZero = if ($WindowsSDKMajorMinorBuildMatch.Success) { $WindowsSDKMajorMinorBuildMatch.Value + ".0" } else { "" }
205202
$CustomWinSDKRoot = $null # Overwritten if we download a Windows SDK from nuget
206203

207204
$vswhere = "${env:ProgramFiles(x86)}\Microsoft Visual Studio\Installer\vswhere.exe"
@@ -670,7 +667,7 @@ function Invoke-VsDevShell($Arch) {
670667
if ($CustomWinSDKRoot) {
671668
$DevCmdArguments += " -winsdk=none"
672669
} elseif ($WinSDKVersion) {
673-
$DevCmdArguments += " -winsdk=$WinSDKVersionRevisionZero"
670+
$DevCmdArguments += " -winsdk=$WinSDKVersion"
674671
}
675672

676673
if ($ToBatch) {
@@ -682,22 +679,22 @@ function Invoke-VsDevShell($Arch) {
682679

683680
if ($CustomWinSDKRoot) {
684681
# Using a non-installed Windows SDK. Setup environment variables manually.
685-
$WinSDKVerIncludeRoot = "$CustomWinSDKRoot\include\$WinSDKVersionRevisionZero"
682+
$WinSDKVerIncludeRoot = "$CustomWinSDKRoot\include\$WinSDKVersion"
686683
$WinSDKIncludePath = "$WinSDKVerIncludeRoot\ucrt;$WinSDKVerIncludeRoot\um;$WinSDKVerIncludeRoot\shared;$WinSDKVerIncludeRoot\winrt;$WinSDKVerIncludeRoot\cppwinrt"
687-
$WinSDKVerLibRoot = "$CustomWinSDKRoot\lib\$WinSDKVersionRevisionZero"
684+
$WinSDKVerLibRoot = "$CustomWinSDKRoot\lib\$WinSDKVersion"
688685

689-
$env:WindowsLibPath = "$CustomWinSDKRoot\UnionMetadata\$WinSDKVersionRevisionZero;$CustomWinSDKRoot\References\$WinSDKVersionRevisionZero"
686+
$env:WindowsLibPath = "$CustomWinSDKRoot\UnionMetadata\$WinSDKVersion;$CustomWinSDKRoot\References\$WinSDKVersion"
690687
$env:WindowsSdkBinPath = "$CustomWinSDKRoot\bin"
691-
$env:WindowsSDKLibVersion = "$WinSDKVersionRevisionZero\"
692-
$env:WindowsSdkVerBinPath = "$CustomWinSDKRoot\bin\$WinSDKVersionRevisionZero"
693-
$env:WindowsSDKVersion = "$WinSDKVersionRevisionZero\"
688+
$env:WindowsSDKLibVersion = "$WinSDKVersion\"
689+
$env:WindowsSdkVerBinPath = "$CustomWinSDKRoot\bin\$WinSDKVersion"
690+
$env:WindowsSDKVersion = "$WinSDKVersion\"
694691

695692
$env:EXTERNAL_INCLUDE += ";$WinSDKIncludePath"
696693
$env:INCLUDE += ";$WinSDKIncludePath"
697694
$env:LIB += ";$WinSDKVerLibRoot\ucrt\$($Arch.ShortName);$WinSDKVerLibRoot\um\$($Arch.ShortName)"
698695
$env:LIBPATH += ";$env:WindowsLibPath"
699696
$env:PATH += ";$env:WindowsSdkVerBinPath\$($Arch.ShortName);$env:WindowsSdkBinPath\$($Arch.ShortName)"
700-
$env:UCRTVersion = $WinSDKVersionRevisionZero
697+
$env:UCRTVersion = $WinSDKVersion
701698
$env:UniversalCRTSdkDir = $CustomWinSDKRoot
702699
}
703700
}
@@ -922,7 +919,7 @@ function Fetch-Dependencies {
922919

923920
foreach ($Arch in $WinSDKArchs) {
924921
Invoke-Program nuget install $Package.$($Arch.ShortName) -Version $WinSDKVersion -OutputDirectory $NugetRoot
925-
Copy-Directory "$NugetRoot\$Package.$($Arch.ShortName).$WinSDKVersion\c\*" "$CustomWinSDKRoot\lib\$WinSDKVersionRevisionZero"
922+
Copy-Directory "$NugetRoot\$Package.$($Arch.ShortName).$WinSDKVersion\c\*" "$CustomWinSDKRoot\lib\$WinSDKVersion"
926923
}
927924
}
928925
}

0 commit comments

Comments
 (0)