[ConstraintSystem] Remove more uses of summaryFlags being set to 0

Author: theblixguy

lib/Sema/CSDiagnostics.cpp

@@ -112,10 +112,9 @@ Optional<SelectedOverload> FailureDiagnostic::getChoiceFor(Expr *expr) {
 
   if (auto *AE = dyn_cast<ApplyExpr>(expr)) {
     if (auto *TE = dyn_cast<TypeExpr>(AE->getFn())) {
-      locator = cs.getConstraintLocator(AE,
-                                        {ConstraintLocator::ApplyFunction,
-                                         ConstraintLocator::ConstructorMember},
-                                        /*summaryFlags=*/0);
+      locator =
+          getConstraintLocator(AE, {ConstraintLocator::ApplyFunction,
+                                    ConstraintLocator::ConstructorMember});
     }
     return getChoiceFor(AE->getFn());
   } else if (auto *UDE = dyn_cast<UnresolvedDotExpr>(expr)) {
@@ -586,10 +585,9 @@ Type NoEscapeFuncToTypeConversionFailure::getParameterTypeFor(
       locator =
           cs.getConstraintLocator(fnExpr, ConstraintLocator::UnresolvedMember);
     } else if (auto *TE = dyn_cast<TypeExpr>(fnExpr)) {
-      locator = cs.getConstraintLocator(call,
-                                        {ConstraintLocator::ApplyFunction,
-                                         ConstraintLocator::ConstructorMember},
-                                        /*summaryFlags=*/0);
+      locator =
+          getConstraintLocator(call, {ConstraintLocator::ApplyFunction,
+                                      ConstraintLocator::ConstructorMember});
     } else {
       locator = cs.getConstraintLocator(fnExpr);
     }

lib/Sema/CSSimplify.cpp

@@ -3437,8 +3437,7 @@ ConstraintSystem::SolutionKind ConstraintSystem::simplifyConformsToConstraint(
         auto reqPath = ArrayRef<LocatorPathElt>(path).drop_back();
         // Underlying conformance requirement is itself fixed,
         // this wouldn't lead to a right solution.
-        if (hasFixFor(getConstraintLocator(anchor, reqPath,
-                                           /*summaryFlags=*/0)))
+        if (hasFixFor(getConstraintLocator(anchor, reqPath)))
           return SolutionKind::Error;
       }
 

lib/Sema/ConstraintSystem.h

@@ -1892,7 +1892,7 @@ class ConstraintSystem {
   /// path, uniqued and automatically infer the summary flags
   ConstraintLocator *
   getConstraintLocator(Expr *anchor,
-                       ArrayRef<ConstraintLocator::PathElement> path);
+                       ArrayRef<ConstraintLocator::PathElement> path) const;
 
   /// Retrieve the constraint locator for the given anchor and
   /// an empty path, uniqued.