[ConstraintSystem] Lift a restriction on fixing of non-function calls on Any/AnyObject

Detect and diagnose situations where call is attempted directly on
`Any` or `AnyObject` or member calls with `AnyObject` base which
didn't match.

Author: xedin

lib/Sema/CSDiagnostics.cpp

@@ -5598,6 +5598,19 @@ bool ExtraneousCallFailure::diagnoseAsError() {
     }
   }
 
+  if (auto *UDE = dyn_cast<UnresolvedDotExpr>(anchor)) {
+    auto *baseExpr = UDE->getBase();
+    auto *call = cast<CallExpr>(getRawAnchor());
+
+    if (getType(baseExpr)->isAnyObject()) {
+      emitDiagnostic(anchor->getLoc(), diag::cannot_call_with_params,
+                     UDE->getName().getBaseName().userFacingName(),
+                     getType(call->getArg())->getString(),
+                     isa<TypeExpr>(baseExpr));
+      return true;
+    }
+  }
+
   auto diagnostic = emitDiagnostic(
       anchor->getLoc(), diag::cannot_call_non_function_value, getType(anchor));
   removeParensFixIt(diagnostic);

lib/Sema/CSSimplify.cpp

@@ -7520,11 +7520,6 @@ ConstraintSystem::simplifyApplicableFnConstraint(
         desugar2->is<AnyMetatypeType>())
       return SolutionKind::Error;
 
-    if (auto objectTy = desugar2->lookThroughAllOptionalTypes()) {
-      if (objectTy->isAny() || objectTy->isAnyObject())
-        return SolutionKind::Error;
-    }
-
     // If there are any type variables associated with arguments/result
     // they have to be marked as "holes".
     type1.visit([&](Type subType) {