Remove resolveProtocolEnvironment, it should be no more needed

Author: xymus

include/swift/AST/LazyResolver.h

@@ -60,9 +60,6 @@ class LazyResolver {
   /// consistency and provides the value a type.
   virtual void resolveDeclSignature(ValueDecl *VD) = 0;
 
-  /// Resolve the generic environment of the given protocol.
-  virtual void resolveProtocolEnvironment(ProtocolDecl *proto) = 0;
-
   /// Resolve the type of an extension.
   ///
   /// This can be called to ensure that the members of an extension can be

lib/Sema/TypeCheckType.cpp

@@ -3422,15 +3422,6 @@ Type TypeChecker::substMemberTypeWithBase(ModuleDecl *module,
           aliasDecl, baseTy,
           aliasDecl->getASTContext());
     }
-
-    // FIXME: If this is a protocol typealias and we haven't built the
-    // protocol's generic environment yet, do so now, to ensure the
-    // typealias's underlying type has fully resolved dependent
-    // member types.
-    if (auto *protoDecl = dyn_cast<ProtocolDecl>(aliasDecl->getDeclContext())) {
-      ASTContext &ctx = protoDecl->getASTContext();
-      ctx.getLazyResolver()->resolveProtocolEnvironment(protoDecl);
-    }
   }
 
   Type resultType;

lib/Sema/TypeChecker.h

@@ -999,10 +999,6 @@ class TypeChecker final : public LazyResolver {
     validateDecl(VD);
   }
 
-  virtual void resolveProtocolEnvironment(ProtocolDecl *proto) override {
-    validateDecl(proto);
-  }
-
   virtual void resolveExtension(ExtensionDecl *ext) override {
     validateExtension(ext);
   }