Merge pull request #2676 from eeckstein/stdlib-performance

Some changes in UnsafeBufferPointer to improve performance

Author: eeckstein

stdlib/public/core/UnsafeBufferPointer.swift.gyb

@@ -57,6 +57,83 @@ public struct Unsafe${Mutable}BufferPointer<Element>
     return count
   }
 
+  public func index(after i: Int) -> Int {
+    // NOTE: this is a manual specialization of index movement for a Strideable
+    // index that is required for UnsafeBufferPointer performance. The
+    // optimizer is not capable of creating partial specializations yet.
+    // NOTE: Range checks are not performed here, because it is done later by
+    // the subscript function.
+    return i + 1
+  }
+
+  public func formIndex(after i: inout Int) {
+    // NOTE: this is a manual specialization of index movement for a Strideable
+    // index that is required for UnsafeBufferPointer performance. The
+    // optimizer is not capable of creating partial specializations yet.
+    // NOTE: Range checks are not performed here, because it is done later by
+    // the subscript function.
+    i += 1
+  }
+
+  public func index(before i: Int) -> Int {
+    // NOTE: this is a manual specialization of index movement for a Strideable
+    // index that is required for UnsafeBufferPointer performance. The
+    // optimizer is not capable of creating partial specializations yet.
+    // NOTE: Range checks are not performed here, because it is done later by
+    // the subscript function.
+    return i - 1
+  }
+
+  public func formIndex(before i: inout Int) {
+    // NOTE: this is a manual specialization of index movement for a Strideable
+    // index that is required for UnsafeBufferPointer performance. The
+    // optimizer is not capable of creating partial specializations yet.
+    // NOTE: Range checks are not performed here, because it is done later by
+    // the subscript function.
+    i -= 1
+  }
+
+  public func index(_ i: Int, offsetBy n: Int) -> Int {
+    // NOTE: this is a manual specialization of index movement for a Strideable
+    // index that is required for UnsafeBufferPointer performance. The
+    // optimizer is not capable of creating partial specializations yet.
+    // NOTE: Range checks are not performed here, because it is done later by
+    // the subscript function.
+    return i + n
+  }
+
+  public func index(
+    _ i: Int, offsetBy n: Int, limitedBy limit: Int
+  ) -> Int? {
+    // NOTE: this is a manual specialization of index movement for a Strideable
+    // index that is required for UnsafeBufferPointer performance. The
+    // optimizer is not capable of creating partial specializations yet.
+    // NOTE: Range checks are not performed here, because it is done later by
+    // the subscript function.
+    let l = limit - i
+    if n > 0 ? l >= 0 && l < n : l <= 0 && n < l {
+      return nil
+    }
+    return i + n
+  }
+
+  public func distance(from start: Int, to end: Int) -> Int {
+    // NOTE: this is a manual specialization of index movement for a Strideable
+    // index that is required for UnsafeBufferPointer performance. The
+    // optimizer is not capable of creating partial specializations yet.
+    // NOTE: Range checks are not performed here, because it is done later by
+    // the subscript function.
+    return end - start
+  }
+
+  public func _failEarlyRangeCheck(_ index: Int, bounds: Range<Int>) {
+    // NOTE: This method is a no-op for performance reasons.
+  }
+
+  public func _failEarlyRangeCheck(_ range: Range<Int>, bounds: Range<Int>) {
+    // NOTE: This method is a no-op for performance reasons.
+  }
+
   public typealias Indices = CountableRange<Int>
 
   public var indices: Indices {
@@ -126,11 +203,10 @@ public struct Unsafe${Mutable}BufferPointer<Element>
 
   /// The number of elements in the buffer.
   public var count: Int {
-    if _position == nil {
-      _sanityCheck(_end == nil)
-      return 0
+    if let pos = _position {
+      return _end! - pos
     }
-    return _end! - _position!
+    return 0
   }
 
   let _position, _end: Unsafe${Mutable}Pointer<Element>?