[AddressLowering] Fix begin_apply's end_borrows.

When a `load_borrow` is created on behalf of a `begin_apply`, it's
possible that it may have escaping users.  When it does,
`findInnerTransitiveGuaranteedUses` returns `false` and the uses it
finds are incomplete.  As a result the boundary computed in
`emitEndBorrows` will be incomplete.

Author: nate-chandler

lib/SILOptimizer/Mandatory/AddressLowering.cpp

@@ -2332,7 +2332,10 @@ void ApplyRewriter::convertBeginApplyWithOpaqueYield() {
       SILValue load =
           resultBuilder.emitLoadBorrowOperation(callLoc, &newResult);
       oldResult.replaceAllUsesWith(load);
-      emitEndBorrows(load, pass);
+      for (auto *user : origCall->getTokenResult()->getUsers()) {
+        pass.getBuilder(user->getIterator())
+            .createEndBorrow(pass.genLoc(), load);
+      }
     } else {
       auto *load = resultBuilder.createTrivialLoadOr(
           callLoc, &newResult, LoadOwnershipQualifier::Take);

test/SILOptimizer/address_lowering.sil

@@ -1590,8 +1590,8 @@ entry:
 // CHECK:         ([[ADDR_1:%[^,]+]], [[ADDR_2:%[^,]+]], {{%[^,]+}}) = begin_apply
 // CHECK:         [[BORROW_1:%[^,]+]] = load_borrow [[ADDR_1]] : $*LoadableNontrivial
 // CHECK:         struct_extract [[BORROW_1]] : $LoadableNontrivial, #LoadableNontrivial.x
-// CHECK:         end_borrow [[BORROW_1]] : $LoadableNontrivial
 // CHECK:         copy_addr [[ADDR_2]] to [init] [[OPAQUE_OUT]] : $*T
+// CHECK:         end_borrow [[BORROW_1]] : $LoadableNontrivial
 // CHECK-LABEL: } // end sil function 'testBeginApply9Yield1LoadableNontrivialGuaranteed1OpaqueGuaranteed'
 sil [ossa] @testBeginApply9Yield1LoadableNontrivialGuaranteed1OpaqueGuaranteed : $@convention(thin) <T> () -> (@out Klass, @out T) {
 entry: