Bridging fidelity: allow removeLastObject() on empty NSMutableArrays

Catfish-Man · Catfish-Man · commit da6adc8ba25a · 2019-10-21T17:20:32.000-07:00
diff --git a/stdlib/public/core/SwiftNativeNSArray.swift b/stdlib/public/core/SwiftNativeNSArray.swift
@@ -241,7 +241,9 @@ extension __SwiftNativeNSArrayWithContiguousStorage: _NSArrayCore {
   
   @objc(removeLastObject)
   dynamic internal func removeLastObject() {
-    contents.removeLast()
+    if !contents.isEmpty {
+      contents.removeLast()
+    }
   }
   
   @objc(replaceObjectAtIndex:withObject:)

Original file line number	Diff line number	Diff line change
`@@ -241,7 +241,9 @@ extension __SwiftNativeNSArrayWithContiguousStorage: _NSArrayCore {`
`241`	`241`
`242`	`242`	`@objc(removeLastObject)`
`243`	`243`	`dynamic internal func removeLastObject() {`
`244`		`- contents.removeLast()`
	`244`	`+ if !contents.isEmpty {`
	`245`	`+ contents.removeLast()`
	`246`	`+ }`
`245`	`247`	`}`
`246`	`248`
`247`	`249`	`@objc(replaceObjectAtIndex:withObject:)`