[region-isolation] Add support for final actor setters.

rdar://119113959

Author: gottesmm

lib/SILOptimizer/Mandatory/TransferNonSendable.cpp

@@ -1033,13 +1033,29 @@ class PartitionOpTranslator {
 
     self->stateIndexToEquivalenceClass[iter.first->second.getID()] = value;
 
-    // Otherwise, we need to compute our flags. Begin by seeing if we have a
-    // value that we can prove is not aliased.
+    // Otherwise, we need to compute our flags.
+
+    // First for addresses.
     if (value->getType().isAddress()) {
-      if (auto accessStorage = AccessStorage::compute(value))
-        if (accessStorage.isUniquelyIdentified() &&
-            !isAddressCapturedByPartialApply)
+      auto storage = AccessStorageWithBase::compute(value);
+      if (storage.storage) {
+        // Check if we have a uniquely identified address that was not captured
+        // by a partial apply... in such a case, we treat it as no-alias.
+        if (storage.storage.isUniquelyIdentified() &&
+            !isAddressCapturedByPartialApply) {
           iter.first->getSecond().removeFlag(TrackableValueFlag::isMayAlias);
+        }
+
+        // Then see if the memory base is a ref_element_addr from an address. If
+        // so, add the actor derived flag.
+        //
+        // This is important so we properly handle setters.
+        if (isa<RefElementAddrInst>(storage.base)) {
+          if (storage.storage.getRoot()->getType().isActor()) {
+            iter.first->getSecond().addFlag(TrackableValueFlag::isActorDerived);
+          }
+        }
+      }
     }
 
     // Then see if we have a sendable value. By default we assume values are not

test/Concurrency/sendnonsendable_basic.swift

@@ -15,7 +15,8 @@
 ////////////////////////
 
 /// Classes are always non-sendable, so this is non-sendable
-class NonSendableKlass { // expected-complete-note 25{{}}
+class NonSendableKlass { // expected-complete-note 31{{}}
+  // expected-tns-note @-1 {{}}
   var field: NonSendableKlass? = nil
 
   func asyncCall() async {}
@@ -50,11 +51,17 @@ struct SingleFieldKlassBox { // expected-complete-note 2{{consider making struct
   var k = NonSendableKlass()
 }
 
-struct TwoFieldKlassBox {
+struct TwoFieldKlassBox { // expected-note {{}}
   var k1 = NonSendableKlass()
   var k2 = NonSendableKlass()
 }
 
+class TwoFieldKlassClassBox {
+  var k1 = NonSendableKlass()
+  var k2 = NonSendableKlass()
+  var recursive: TwoFieldKlassClassBox? = nil
+}
+
 ////////////////////////////
 // MARK: Actor Self Tests //
 ////////////////////////////
@@ -1266,3 +1273,53 @@ func controlFlowTest2() async {
 
   useValue(x) // expected-tns-note {{access here could race}}
 }
+
+////////////////////////
+// MARK: Actor Setter //
+////////////////////////
+
+final actor ActorWithSetter {
+  var field = NonSendableKlass()
+  var twoFieldBox = TwoFieldKlassBox()
+  var twoFieldBoxInTuple = (NonSendableKlass(), TwoFieldKlassBox())
+  var recursive: ActorWithSetter? = nil
+  var classBox = TwoFieldKlassClassBox()
+
+  func test1() async {
+    let x = NonSendableKlass()
+    self.field = x
+    await transferToMain(x) // expected-tns-warning {{call site passes `self` or a non-sendable argument of this function to another thread, potentially yielding a race with the caller}}
+    // expected-complete-warning @-1 {{passing argument of non-sendable type 'NonSendableKlass' into main actor-isolated context may introduce data races}}
+  }
+
+  func test2() async {
+    let x = NonSendableKlass()
+    self.twoFieldBox.k1 = x
+    await transferToMain(x) // expected-tns-warning {{call site passes `self` or a non-sendable argument of this function to another thread, potentially yielding a race with the caller}}
+    // expected-complete-warning @-1 {{passing argument of non-sendable type 'NonSendableKlass' into main actor-isolated context may introduce data races}}
+  }
+
+  func test3() async {
+    let x = NonSendableKlass()
+    self.twoFieldBoxInTuple.1.k1 = x
+    await transferToMain(x) // expected-tns-warning {{call site passes `self` or a non-sendable argument of this function to another thread, potentially yielding a race with the caller}}
+    // expected-complete-warning @-1 {{passing argument of non-sendable type 'NonSendableKlass' into main actor-isolated context may introduce data races}}    
+  }
+
+  func recursive() async {
+    let x = NonSendableKlass()
+    await self.recursive!.twoFieldBoxInTuple.1.k2 = x
+    // expected-warning @-1 {{non-sendable type '(NonSendableKlass, TwoFieldKlassBox)' in implicitly asynchronous access to actor-isolated property 'twoFieldBoxInTuple' cannot cross actor boundary}}
+    // expected-warning @-2 {{non-sendable type '(NonSendableKlass, TwoFieldKlassBox)' in implicitly asynchronous access to actor-isolated property 'twoFieldBoxInTuple' cannot cross actor boundary}}
+
+    await transferToMain(x) // expected-tns-warning {{call site passes `self` or a non-sendable argument of this function to another thread, potentially yielding a race with the caller}}
+    // expected-complete-warning @-1 {{passing argument of non-sendable type 'NonSendableKlass' into main actor-isolated context may introduce data races}}
+  }
+
+  func classBox() async {
+    let x = NonSendableKlass()
+    self.classBox.k1 = x
+    await transferToMain(x) // expected-tns-warning {{call site passes `self` or a non-sendable argument of this function to another thread, potentially yielding a race with the caller}}
+    // expected-complete-warning @-1 {{passing argument of non-sendable type 'NonSendableKlass' into main actor-isolated context may introduce data races}}
+  }
+}