[libSyntax] Delete discardRecordedNode

It doesn't do anything anymore and we shouldn't have it, so let's just
remove it.

Author: ahoppen

include/swift/Parse/ParsedRawSyntaxRecorder.h

@@ -67,8 +67,6 @@ class ParsedRawSyntaxRecorder final {
   ParsedRawSyntaxNode recordEmptyRawSyntaxCollection(syntax::SyntaxKind kind,
                                                      SourceLoc loc);
 
-  void discardRecordedNode(ParsedRawSyntaxNode &node);
-
   /// Used for incremental re-parsing.
   ParsedRawSyntaxNode lookupNode(size_t lexerOffset, SourceLoc loc,
                                  syntax::SyntaxKind kind);

include/swift/Parse/SyntaxParseActions.h

@@ -62,13 +62,6 @@ class SyntaxParseActions {
   virtual Optional<syntax::SourceFileSyntax>
   realizeSyntaxRoot(OpaqueSyntaxNode root, const SourceFile &SF) = 0;
 
-  /// Discard raw syntax node.
-  /// 
-  /// FIXME: This breaks invariant that any recorded node will be a part of the
-  /// result SourceFile syntax. This method is a temporary workaround, and
-  /// should be removed when we fully migrate to libSyntax parsing.
-  virtual void discardRecordedNode(OpaqueSyntaxNode node) = 0;
-
   /// Used for incremental re-parsing.
   virtual std::pair<size_t, OpaqueSyntaxNode>
   lookupNode(size_t lexerOffset, syntax::SyntaxKind kind) {

include/swift/SyntaxParse/SyntaxTreeCreator.h

@@ -73,8 +73,6 @@ class SyntaxTreeCreator: public SyntaxParseActions {
                                    ArrayRef<OpaqueSyntaxNode> elements,
                                    CharSourceRange range) override;
 
-  void discardRecordedNode(OpaqueSyntaxNode node) override;
-
   std::pair<size_t, OpaqueSyntaxNode>
   lookupNode(size_t lexerOffset, syntax::SyntaxKind kind) override;
 };

lib/Parse/ParsedRawSyntaxRecorder.cpp

@@ -112,10 +112,6 @@ ParsedRawSyntaxRecorder::recordEmptyRawSyntaxCollection(SyntaxKind kind,
   return ParsedRawSyntaxNode{kind, tok::unknown, range, n};
 }
 
-void ParsedRawSyntaxRecorder::discardRecordedNode(ParsedRawSyntaxNode &node) {
-  SPActions->discardRecordedNode(node.takeOpaqueNode());
-}
-
 ParsedRawSyntaxNode
 ParsedRawSyntaxRecorder::lookupNode(size_t lexerOffset, SourceLoc loc,
                                     SyntaxKind kind) {

lib/Parse/SyntaxParsingContext.cpp

@@ -405,12 +405,6 @@ SyntaxParsingContext::~SyntaxParsingContext() {
   // Remove all parts in this context.
   case AccumulationMode::Discard: {
     auto &nodes = getStorage();
-    for (auto i = nodes.begin()+Offset, e = nodes.end(); i != e; ++i) {
-      // FIXME: This should not be needed. This breaks invariant that any
-      // recorded node must be a part of result souce syntax tree.
-      if (i->isRecorded())
-        getRecorder().discardRecordedNode(*i);
-    }
     nodes.erase(nodes.begin()+Offset, nodes.end());
     break;
   }

lib/SyntaxParse/SyntaxTreeCreator.cpp

@@ -165,6 +165,3 @@ SyntaxTreeCreator::lookupNode(size_t lexerOffset, syntax::SyntaxKind kind) {
   size_t length = raw->getTextLength();
   return {length, static_cast<OpaqueSyntaxNode>(raw)};
 }
-
-void SyntaxTreeCreator::discardRecordedNode(OpaqueSyntaxNode opaqueN) {
-}

tools/libSwiftSyntaxParser/libSwiftSyntaxParser.cpp

@@ -197,10 +197,6 @@ class CLibParseActions : public SyntaxParseActions {
     return None;
   }
 
-  void discardRecordedNode(OpaqueSyntaxNode node) override {
-    // FIXME: This method should not be called at all.
-  }
-
   std::pair<size_t, OpaqueSyntaxNode>
   lookupNode(size_t lexerOffset, SyntaxKind kind) override {
     auto NodeLookup = getNodeLookup();