[AST] Make DeclAttributes::getAttribute() propagate its AllowInvalid bit.

DougGregor · DougGregor · commit dcf53dcea0db · 2018-07-03T17:18:09.000-07:00
Because, you know, I’d like it to do what it says it does.
diff --git a/include/swift/AST/Attr.h b/include/swift/AST/Attr.h
@@ -1385,7 +1385,7 @@ class DeclAttributes {
   /// Retrieve the first attribute of the given attribute class.
   template <typename ATTR>
   const ATTR *getAttribute(bool AllowInvalid = false) const {
-    return const_cast<DeclAttributes *>(this)->getAttribute<ATTR>();
+    return const_cast<DeclAttributes *>(this)->getAttribute<ATTR>(AllowInvalid);
   }
 
   template <typename ATTR>

Original file line number	Diff line number	Diff line change
`@@ -1385,7 +1385,7 @@ class DeclAttributes {`
`1385`	`1385`	`/// Retrieve the first attribute of the given attribute class.`
`1386`	`1386`	`template <typename ATTR>`
`1387`	`1387`	`const ATTR *getAttribute(bool AllowInvalid = false) const {`
`1388`		`- return const_cast<DeclAttributes *>(this)->getAttribute<ATTR>();`
	`1388`	`+ return const_cast<DeclAttributes *>(this)->getAttribute<ATTR>(AllowInvalid);`
`1389`	`1389`	`}`
`1390`	`1390`
`1391`	`1391`	`template <typename ATTR>`