Merge pull request #23476 from shajrawi/no_tail

ARCEntryPointBuilder: Don't mark the call instructions as tail-calls

Author: Joe Shajrawi

lib/LLVMPasses/ARCEntryPointBuilder.h

@@ -119,7 +119,6 @@ class ARCEntryPointBuilder {
 
     // Create the call.
     CallInst *CI = CreateCall(getRetain(OrigI), V);
-    CI->setTailCall(true);
     return CI;
   }
 
@@ -129,7 +128,6 @@ class ARCEntryPointBuilder {
 
     // Create the call.
     CallInst *CI = CreateCall(getRelease(OrigI), V);
-    CI->setTailCall(true);
     return CI;
   }
 
@@ -139,23 +137,20 @@ class ARCEntryPointBuilder {
     V = B.CreatePointerCast(V, getObjectPtrTy());
 
     CallInst *CI = CreateCall(getCheckUnowned(OrigI), V);
-    CI->setTailCall(true);
     return CI;
   }
 
   CallInst *createRetainN(Value *V, uint32_t n, CallInst *OrigI) {
     // Cast just to make sure that we have the right object type.
     V = B.CreatePointerCast(V, getObjectPtrTy());
     CallInst *CI = CreateCall(getRetainN(OrigI), {V, getIntConstant(n)});
-    CI->setTailCall(true);
     return CI;
   }
 
   CallInst *createReleaseN(Value *V, uint32_t n, CallInst *OrigI) {
     // Cast just to make sure we have the right object type.
     V = B.CreatePointerCast(V, getObjectPtrTy());
     CallInst *CI = CreateCall(getReleaseN(OrigI), {V, getIntConstant(n)});
-    CI->setTailCall(true);
     return CI;
   }
 
@@ -164,7 +159,6 @@ class ARCEntryPointBuilder {
     V = B.CreatePointerCast(V, getObjectPtrTy());
     CallInst *CI =
         CreateCall(getUnknownObjectRetainN(OrigI), {V, getIntConstant(n)});
-    CI->setTailCall(true);
     return CI;
   }
 
@@ -173,23 +167,20 @@ class ARCEntryPointBuilder {
     V = B.CreatePointerCast(V, getObjectPtrTy());
     CallInst *CI =
         CreateCall(getUnknownObjectReleaseN(OrigI), {V, getIntConstant(n)});
-    CI->setTailCall(true);
     return CI;
   }
 
   CallInst *createBridgeRetainN(Value *V, uint32_t n, CallInst *OrigI) {
     // Cast just to make sure we have the right object type.
     V = B.CreatePointerCast(V, getBridgeObjectPtrTy());
     CallInst *CI = CreateCall(getBridgeRetainN(OrigI), {V, getIntConstant(n)});
-    CI->setTailCall(true);
     return CI;
   }
 
   CallInst *createBridgeReleaseN(Value *V, uint32_t n, CallInst *OrigI) {
     // Cast just to make sure we have the right object type.
     V = B.CreatePointerCast(V, getBridgeObjectPtrTy());
     CallInst *CI = CreateCall(getBridgeReleaseN(OrigI), {V, getIntConstant(n)});
-    CI->setTailCall(true);
     return CI;
   }