ASTBridging: Bridge swift::PlatformKind directly

Author: AnthonyLatsis

include/swift/AST/ASTBridging.h

@@ -26,6 +26,7 @@
 #include "swift/AST/DiagnosticList.h"
 #include "swift/AST/GenericTypeParamKind.h"
 #include "swift/AST/LayoutConstraintKind.h"
+#include "swift/AST/PlatformKind.h"
 #include "swift/Basic/BasicBridging.h"
 
 #ifdef USED_IN_CPP_SOURCE
@@ -67,7 +68,6 @@ class MacroIntroducedDeclName;
 enum class MacroIntroducedDeclNameKind;
 enum class ParamSpecifier : uint8_t;
 class ParsedAutoDiffParameter;
-enum class PlatformKind : uint8_t;
 class ProtocolConformanceRef;
 class RegexLiteralPatternFeature;
 class RegexLiteralPatternFeatureKind;
@@ -88,7 +88,6 @@ struct BridgedSubstitutionMap;
 struct BridgedGenericSignature;
 struct BridgedConformance;
 class BridgedParameterList;
-enum BridgedPlatformKind : size_t;
 
 // Forward declare the underlying AST node type for each wrapper.
 namespace swift {
@@ -683,20 +682,14 @@ BridgedClosureExpr_asDeclContext(BridgedClosureExpr cClosure);
 // MARK: Availability
 //===----------------------------------------------------------------------===//
 
-enum ENUM_EXTENSIBILITY_ATTR(closed) BridgedPlatformKind : size_t {
-  BridgedPlatformKind_None,
-#define AVAILABILITY_PLATFORM(X, PrettyName) BridgedPlatformKind_##X,
-#include "swift/AST/PlatformKinds.def"
-};
-
-SWIFT_NAME("BridgedPlatformKind.init(from:)")
-BridgedPlatformKind BridgedPlatformKind_fromString(BridgedStringRef cStr);
+BRIDGED_OPTIONAL(swift::PlatformKind, PlatformKind)
 
-SWIFT_NAME("BridgedPlatformKind.init(from:)")
-BridgedPlatformKind
-BridgedPlatformKind_fromIdentifier(BridgedIdentifier cIdent);
+SWIFT_NAME("BridgedOptionalPlatformKind.init(from:)")
+BridgedOptionalPlatformKind PlatformKind_fromString(BridgedStringRef cStr);
 
-swift::PlatformKind unbridge(BridgedPlatformKind cPlatform);
+SWIFT_NAME("BridgedOptionalPlatformKind.init(from:)")
+BridgedOptionalPlatformKind
+PlatformKind_fromIdentifier(BridgedIdentifier cIdent);
 
 SWIFT_NAME("BridgedAvailabilityMacroMap.has(self:name:)")
 bool BridgedAvailabilityMacroMap_hasName(BridgedAvailabilityMacroMap map,
@@ -931,7 +924,7 @@ SWIFT_NAME(
     "BridgedBackDeployedAttr.createParsed(_:atLoc:range:platform:version:)")
 BridgedBackDeployedAttr BridgedBackDeployedAttr_createParsed(
     BridgedASTContext cContext, BridgedSourceLoc cAtLoc,
-    BridgedSourceRange cRange, BridgedPlatformKind cPlatform,
+    BridgedSourceRange cRange, swift::PlatformKind platform,
     BridgedVersionTuple cVersion);
 
 SWIFT_NAME("BridgedCDeclAttr.createParsed(_:atLoc:range:name:)")
@@ -1161,7 +1154,7 @@ SWIFT_NAME("BridgedOriginallyDefinedInAttr.createParsed(_:atLoc:range:"
 BridgedOriginallyDefinedInAttr BridgedOriginallyDefinedInAttr_createParsed(
     BridgedASTContext cContext, BridgedSourceLoc cAtLoc,
     BridgedSourceRange cRange, BridgedStringRef cModuleName,
-    BridgedPlatformKind cPlatform, BridgedVersionTuple cVersion);
+    swift::PlatformKind platform, BridgedVersionTuple cVersion);
 
 SWIFT_NAME("BridgedStorageRestrictionsAttr.createParsed(_:atLoc:range:"
            "initializes:accesses:)")

include/swift/AST/Attr.h

@@ -28,7 +28,7 @@
 #include "swift/AST/LifetimeDependence.h"
 #include "swift/AST/MacroDeclaration.h"
 #include "swift/AST/Ownership.h"
-#include "swift/AST/PlatformKind.h"
+#include "swift/AST/PlatformKindUtils.h"
 #include "swift/AST/StorageImpl.h"
 #include "swift/Basic/Debug.h"
 #include "swift/Basic/EnumTraits.h"
@@ -41,10 +41,10 @@
 #include "swift/Basic/SourceLoc.h"
 #include "swift/Basic/UUID.h"
 #include "swift/Basic/Version.h"
-#include "llvm/ADT/bit.h"
 #include "llvm/ADT/DenseMapInfo.h"
 #include "llvm/ADT/SmallVector.h"
 #include "llvm/ADT/StringRef.h"
+#include "llvm/ADT/bit.h"
 #include "llvm/ADT/iterator_range.h"
 #include "llvm/Support/ErrorHandling.h"
 #include "llvm/Support/TrailingObjects.h"

include/swift/AST/AvailabilityConstraint.h

@@ -2,7 +2,7 @@
 //
 // This source file is part of the Swift.org open source project
 //
-// Copyright (c) 2024 Apple Inc. and the Swift project authors
+// Copyright (c) 2024 - 2025 Apple Inc. and the Swift project authors
 // Licensed under Apache License v2.0 with Runtime Library Exception
 //
 // See https://swift.org/LICENSE.txt for license information
@@ -20,7 +20,7 @@
 #include "swift/AST/Attr.h"
 #include "swift/AST/AvailabilityDomain.h"
 #include "swift/AST/AvailabilityRange.h"
-#include "swift/AST/PlatformKind.h"
+#include "swift/AST/PlatformKindUtils.h"
 #include "swift/Basic/LLVM.h"
 #include "swift/Basic/OptionSet.h"
 

include/swift/AST/AvailabilityContext.h

@@ -2,7 +2,7 @@
 //
 // This source file is part of the Swift.org open source project
 //
-// Copyright (c) 2024 Apple Inc. and the Swift project authors
+// Copyright (c) 2024 - 2025 Apple Inc. and the Swift project authors
 // Licensed under Apache License v2.0 with Runtime Library Exception
 //
 // See https://swift.org/LICENSE.txt for license information
@@ -20,7 +20,7 @@
 
 #include "swift/AST/AvailabilityDomain.h"
 #include "swift/AST/AvailabilityRange.h"
-#include "swift/AST/PlatformKind.h"
+#include "swift/AST/PlatformKindUtils.h"
 #include "swift/Basic/Debug.h"
 #include "swift/Basic/LLVM.h"
 #include <optional>

include/swift/AST/AvailabilityDomain.h

@@ -2,7 +2,7 @@
 //
 // This source file is part of the Swift.org open source project
 //
-// Copyright (c) 2024 Apple Inc. and the Swift project authors
+// Copyright (c) 2024 - 2025 Apple Inc. and the Swift project authors
 // Licensed under Apache License v2.0 with Runtime Library Exception
 //
 // See https://swift.org/LICENSE.txt for license information
@@ -21,7 +21,7 @@
 #include "swift/AST/ASTAllocated.h"
 #include "swift/AST/AvailabilityRange.h"
 #include "swift/AST/Identifier.h"
-#include "swift/AST/PlatformKind.h"
+#include "swift/AST/PlatformKindUtils.h"
 #include "swift/Basic/Assertions.h"
 #include "swift/Basic/LLVM.h"
 #include "swift/Basic/SourceLoc.h"

include/swift/AST/AvailabilitySpec.h

@@ -2,7 +2,7 @@
 //
 // This source file is part of the Swift.org open source project
 //
-// Copyright (c) 2014 - 2017 Apple Inc. and the Swift project authors
+// Copyright (c) 2014 - 2025 Apple Inc. and the Swift project authors
 // Licensed under Apache License v2.0 with Runtime Library Exception
 //
 // See https://swift.org/LICENSE.txt for license information
@@ -20,7 +20,7 @@
 #include "swift/AST/ASTAllocated.h"
 #include "swift/AST/AvailabilityDomain.h"
 #include "swift/AST/Identifier.h"
-#include "swift/AST/PlatformKind.h"
+#include "swift/AST/PlatformKindUtils.h"
 #include "swift/Basic/STLExtras.h"
 #include "swift/Basic/SourceLoc.h"
 #include "llvm/ADT/DenseMap.h"

include/swift/AST/PlatformKind.h

@@ -1,108 +1,36 @@
-//===--- PlatformKind.h - Swift Language Platform Kinds ---------*- C++ -*-===//
+//===--- AST/PlatformKind.h - Swift Language Platform Kinds -----*- C++ -*-===//
 //
 // This source file is part of the Swift.org open source project
 //
-// Copyright (c) 2014 - 2017 Apple Inc. and the Swift project authors
+// Copyright (c) 2025 Apple Inc. and the Swift project authors
 // Licensed under Apache License v2.0 with Runtime Library Exception
 //
 // See https://swift.org/LICENSE.txt for license information
 // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 //
 //===----------------------------------------------------------------------===//
-//
-// This file defines the platform kinds for API availability.
-//
+///
+/// This file defines the platform kinds for API availability.
+///
 //===----------------------------------------------------------------------===//
 
 #ifndef SWIFT_AST_PLATFORM_KIND_H
 #define SWIFT_AST_PLATFORM_KIND_H
 
-#include "swift/Basic/LLVM.h"
-#include "swift/Config.h"
-#include "llvm/ADT/StringRef.h"
-#include "llvm/Support/VersionTuple.h"
-#include "llvm/TargetParser/Triple.h"
-#include <optional>
+/// This header is included in a bridging header. Be *very* careful with what
+/// you include here! See include caveats in `ASTBridging.h`.
+#include "swift/Basic/SwiftBridging.h"
+#include <stdint.h>
 
 namespace swift {
 
-class LangOptions;
-
 /// Available platforms for the availability attribute.
-enum class PlatformKind: uint8_t {
+enum class ENUM_EXTENSIBILITY_ATTR(closed) PlatformKind : uint8_t {
   none,
 #define AVAILABILITY_PLATFORM(X, PrettyName) X,
 #include "swift/AST/PlatformKinds.def"
 };
 
-/// Returns the short string representing the platform, suitable for
-/// use in availability specifications (e.g., "OSX").
-StringRef platformString(PlatformKind platform);
-  
-/// Returns the platform kind corresponding to the passed-in short platform name
-/// or None if such a platform kind does not exist.
-std::optional<PlatformKind> platformFromString(StringRef Name);
-
-/// Safely converts the given unsigned value to a valid \c PlatformKind value or
-/// \c nullopt otherwise.
-std::optional<PlatformKind> platformFromUnsigned(unsigned value);
-
-/// Returns a valid platform string that is closest to the candidate string
-/// based on edit distance. Returns \c None if the closest valid platform
-/// distance is not within a minimum threshold.
-std::optional<StringRef> closestCorrectedPlatformString(StringRef candidate);
-
-/// Returns a human-readable version of the platform name as a string, suitable
-/// for emission in diagnostics (e.g., "macOS").
-StringRef prettyPlatformString(PlatformKind platform);
-
-/// Returns the base platform for an application-extension platform. For example
-/// `iOS` would be returned for `iOSApplicationExtension`. Returns `None` for
-/// platforms which are not application extension platforms.
-std::optional<PlatformKind>
-basePlatformForExtensionPlatform(PlatformKind Platform);
-
-/// Returns true if \p Platform represents and application extension platform,
-/// e.g. `iOSApplicationExtension`.
-inline bool isApplicationExtensionPlatform(PlatformKind Platform) {
-  return basePlatformForExtensionPlatform(Platform).has_value();
-}
-
-/// Returns whether the passed-in platform is active, given the language
-/// options. A platform is active if either it is the target platform or its
-/// AppExtension variant is the target platform. For example, OS X is
-/// considered active when the target operating system is OS X and app extension
-/// restrictions are enabled, but OSXApplicationExtension is not considered
-/// active when the target platform is OS X and app extension restrictions are
-/// disabled. PlatformKind::none is always considered active.
-/// If ForTargetVariant is true then for zippered builds the target-variant
-/// triple will be used rather than the target to determine whether the
-/// platform is active.
-bool isPlatformActive(PlatformKind Platform, const LangOptions &LangOpts,
-                      bool ForTargetVariant = false, bool ForRuntimeQuery = false);
-
-/// Returns the target platform for the given language options.
-PlatformKind targetPlatform(const LangOptions &LangOpts);
-
-/// Returns the target variant platform for the given language options.
-PlatformKind targetVariantPlatform(const LangOptions &LangOpts);
-
-/// Returns true when availability attributes from the "parent" platform
-/// should also apply to the "child" platform for declarations without
-/// an explicit attribute for the child.
-bool inheritsAvailabilityFromPlatform(PlatformKind Child, PlatformKind Parent);
-
-/// Returns the LLVM triple OS type for the given platform, if there is one.
-std::optional<llvm::Triple::OSType>
-tripleOSTypeForPlatform(PlatformKind platform);
-
-llvm::VersionTuple canonicalizePlatformVersion(
-    PlatformKind platform, const llvm::VersionTuple &version);
-
-/// Returns true if \p Platform should be considered to be SPI and therefore not
-/// printed in public `.swiftinterface` files, for example.
-bool isPlatformSPI(PlatformKind Platform);
-
 } // end namespace swift
 
-#endif
+#endif // SWIFT_AST_PLATFORM_KIND_H

include/swift/AST/PlatformKindUtils.h

@@ -0,0 +1,101 @@
+//===--- AST/PlatformKindUtils.h --------------------------------*- C++ -*-===//
+//
+// This source file is part of the Swift.org open source project
+//
+// Copyright (c) 2014 - 2025 Apple Inc. and the Swift project authors
+// Licensed under Apache License v2.0 with Runtime Library Exception
+//
+// See https://swift.org/LICENSE.txt for license information
+// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
+//
+//===----------------------------------------------------------------------===//
+///
+/// This file declares operations for working with `PlatformKind`.
+///
+//===----------------------------------------------------------------------===//
+
+#ifndef SWIFT_AST_PLATFORM_KIND_UTILS_H
+#define SWIFT_AST_PLATFORM_KIND_UTILS_H
+
+#include "swift/AST/PlatformKind.h"
+#include "swift/Basic/LLVM.h"
+#include "swift/Config.h"
+#include "llvm/Support/VersionTuple.h"
+#include "llvm/TargetParser/Triple.h"
+#include <optional>
+
+namespace swift {
+
+class LangOptions;
+
+/// Returns the short string representing the platform, suitable for
+/// use in availability specifications (e.g., "OSX").
+StringRef platformString(PlatformKind platform);
+
+/// Returns the platform kind corresponding to the passed-in short platform name
+/// or None if such a platform kind does not exist.
+std::optional<PlatformKind> platformFromString(StringRef Name);
+
+/// Safely converts the given unsigned value to a valid \c PlatformKind value or
+/// \c nullopt otherwise.
+std::optional<PlatformKind> platformFromUnsigned(unsigned value);
+
+/// Returns a valid platform string that is closest to the candidate string
+/// based on edit distance. Returns \c None if the closest valid platform
+/// distance is not within a minimum threshold.
+std::optional<StringRef> closestCorrectedPlatformString(StringRef candidate);
+
+/// Returns a human-readable version of the platform name as a string, suitable
+/// for emission in diagnostics (e.g., "macOS").
+StringRef prettyPlatformString(PlatformKind platform);
+
+/// Returns the base platform for an application-extension platform. For example
+/// `iOS` would be returned for `iOSApplicationExtension`. Returns `None` for
+/// platforms which are not application extension platforms.
+std::optional<PlatformKind>
+basePlatformForExtensionPlatform(PlatformKind Platform);
+
+/// Returns true if \p Platform represents and application extension platform,
+/// e.g. `iOSApplicationExtension`.
+inline bool isApplicationExtensionPlatform(PlatformKind Platform) {
+  return basePlatformForExtensionPlatform(Platform).has_value();
+}
+
+/// Returns whether the passed-in platform is active, given the language
+/// options. A platform is active if either it is the target platform or its
+/// AppExtension variant is the target platform. For example, OS X is
+/// considered active when the target operating system is OS X and app extension
+/// restrictions are enabled, but OSXApplicationExtension is not considered
+/// active when the target platform is OS X and app extension restrictions are
+/// disabled. PlatformKind::none is always considered active.
+/// If ForTargetVariant is true then for zippered builds the target-variant
+/// triple will be used rather than the target to determine whether the
+/// platform is active.
+bool isPlatformActive(PlatformKind Platform, const LangOptions &LangOpts,
+                      bool ForTargetVariant = false, bool ForRuntimeQuery = false);
+
+/// Returns the target platform for the given language options.
+PlatformKind targetPlatform(const LangOptions &LangOpts);
+
+/// Returns the target variant platform for the given language options.
+PlatformKind targetVariantPlatform(const LangOptions &LangOpts);
+
+/// Returns true when availability attributes from the "parent" platform
+/// should also apply to the "child" platform for declarations without
+/// an explicit attribute for the child.
+bool inheritsAvailabilityFromPlatform(PlatformKind Child, PlatformKind Parent);
+
+/// Returns the LLVM triple OS type for the given platform, if there is one.
+std::optional<llvm::Triple::OSType>
+tripleOSTypeForPlatform(PlatformKind platform);
+
+llvm::VersionTuple canonicalizePlatformVersion(
+    PlatformKind platform, const llvm::VersionTuple &version);
+
+/// Returns true if \p Platform should be considered to be SPI and therefore not
+/// printed in public `.swiftinterface` files, for example.
+bool isPlatformSPI(PlatformKind Platform);
+
+} // end namespace swift
+
+#endif // SWIFT_AST_PLATFORM_KIND_UTILS_H