[Macros] Fix MacroDecl serialization crash with custom parameter attributes

Type-check `MacroDecl`'s parameter list so that custom attributes on parameters will have a type. Fixes a serialization crash.

Author: rxwei

include/swift/AST/Decl.h

@@ -8418,6 +8418,9 @@ class MacroDecl : public GenericContext, public ValueDecl {
   /// Retrieve the definition of this macro.
   MacroDefinition getDefinition() const;
 
+  /// Retrieve the parameter list of this macro.
+  ParameterList *getParameterList() const { return parameterList; }
+
   /// Retrieve the builtin macro kind for this macro, or \c None if it is a
   /// user-defined macro with no special semantics.
   Optional<BuiltinMacroKind> getBuiltinKind() const;

lib/Sema/TypeCheckAccess.cpp

@@ -1174,7 +1174,6 @@ class UsableFromInlineChecker : public AccessControlCheckerBase,
   UNINTERESTING(Destructor) // Always correct.
   UNINTERESTING(Accessor) // Handled by the Var or Subscript.
   UNINTERESTING(OpaqueType) // Handled by the Var or Subscript.
-  UNINTERESTING(Macro)
 
   /// If \p VD's layout is exposed by a @frozen struct or class, return said
   /// struct or class.
@@ -1569,6 +1568,10 @@ class UsableFromInlineChecker : public AccessControlCheckerBase,
     }
   }
 
+  void visitMacroDecl(MacroDecl *MD) {
+    // FIXME: Check access of macro generic parameters, parameters and result
+  }
+
   void visitEnumElementDecl(EnumElementDecl *EED) {
     if (!EED->hasAssociatedValues())
       return;

lib/Sema/TypeCheckDeclPrimary.cpp

@@ -2019,6 +2019,8 @@ class DeclChecker : public DeclVisitor<DeclChecker> {
     if (!MD->getAttrs().hasAttribute<MacroRoleAttr>(/*AllowInvalid*/ true))
       MD->diagnose(diag::macro_without_role, MD->getName());
 
+    TypeChecker::checkParameterList(MD->getParameterList(), MD);
+
     // Check the macro definition.
     switch (auto macroDef = MD->getDefinition()) {
     case MacroDefinition::Kind::Undefined:

test/Serialization/Inputs/macro_decl.swift

@@ -0,0 +1,7 @@
+@resultBuilder
+public struct Builder {
+  static func buildBlock(_: Int...) -> Void {}
+}
+@freestanding(expression)
+public macro macroWithBuilderArgs(@Builder _: () -> Void) = #externalMacro(module: "A", type: "B")
+// expected-warning@-1{{external macro implementation type 'A.B' could not be found for macro 'macroWithBuilderArgs'}}

test/Serialization/macro_decl.swift

@@ -0,0 +1,13 @@
+// RUN: %empty-directory(%t)
+// RUN: %target-swift-frontend -emit-module -module-name macro_decl -o %t %S/Inputs/macro_decl.swift -enable-library-evolution -enable-experimental-feature Macros
+// RUN: llvm-bcanalyzer %t/macro_decl.swiftmodule | %FileCheck %s
+// RUN: %target-swift-frontend -typecheck -I %t %s -o /dev/null
+// RUN: %target-swift-frontend -emit-sil -I %t %s -o /dev/null
+
+// RUN: %target-swift-ide-test(mock-sdk: %clang-importer-sdk) -print-module -module-to-print=macro_decl -I %t -source-filename=%s | %FileCheck -check-prefix=CHECK-PRINT %s
+
+// CHECK: MACRO_DECL
+
+// CHECK-NOT: UnknownCode
+
+// CHECK-PRINT-DAG: macro macroWithBuilderArgs(@Builder _: () -> Void)