Skip to content

Commit e0b220c

Browse files
authored
Merge pull request #25063 from brentdax/dash-a
Add build-script -a/-A to control assertions
2 parents 4b1bb8f + a60e0e0 commit e0b220c

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

utils/build_swift/driver_arguments.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -663,12 +663,12 @@ def create_argument_parser():
663663
set_defaults(assertions=True)
664664

665665
# TODO: Convert to store_true
666-
option('--assertions', store,
666+
option(['-a', '--assertions'], store,
667667
const=True,
668668
help='enable assertions in all projects')
669669

670670
# TODO: Convert to store_false
671-
option('--no-assertions', store('assertions'),
671+
option(['-A', '--no-assertions'], store('assertions'),
672672
const=False,
673673
help='disable assertions in all projects')
674674

utils/build_swift/tests/expected_options.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -386,9 +386,11 @@ class IgnoreOption(_BaseOption):
386386
SetOption('-s', dest='test_optimize_for_size', value=True),
387387
SetOption('-y', dest='test_optimize_none_implicit_dynamic', value=True),
388388
SetOption('-t', dest='test', value=True),
389+
SetOption('-a', dest='assertions', value=True),
389390

390391
# FIXME: Convert these options to set_false actions
391392
SetOption('--no-assertions', dest='assertions', value=False),
393+
SetOption('-A', dest='assertions', value=False),
392394
SetOption('--no-lldb-assertions', dest='lldb_assertions', value=False),
393395
SetOption('--no-llvm-assertions', dest='llvm_assertions', value=False),
394396
SetOption('--no-llbuild-assertions',

0 commit comments

Comments
 (0)