Keep more ParenType parameter flags when canonicalizing function types (#17369) (#17380)

This will also preserve @escaping and @autoclosure, which were previously
dropped. This could lead to mismatches between expected and actual
canonical types for serialization cross-references.

https://bugs.swift.org/browse/SR-8045, likely others
(cherry picked from commit 8abaaea)

Author: jrose-apple

lib/AST/Type.cpp

@@ -1061,9 +1061,8 @@ getCanonicalInputType(AnyFunctionType *funcType,
 
   auto flags = ParameterTypeFlags().withInOut(inputType->is<InOutType>());
   if (auto *parenTy = dyn_cast<ParenType>(origInputType.getPointer())) {
-    auto parenFlags = parenTy->getParameterFlags();
-    flags =
-        flags.withShared(parenFlags.isShared()).withOwned(parenFlags.isOwned());
+    flags = parenTy->getParameterFlags().withInOut(flags.isInOut());
+    assert(!flags.isVariadic() && "variadic ParenType");
   }
 
   inputType = ParenType::get(inputType->getASTContext(),

validation-test/Serialization/Inputs/SR8045-other.swift

@@ -0,0 +1,5 @@
+public typealias Alias<T> = (T) -> ()
+
+public class Super {
+  public func foo(_ f: @escaping Alias<Bool>) {}
+}

validation-test/Serialization/SR8045.swift

@@ -0,0 +1,6 @@
+// RUN: %empty-directory(%t)
+// RUN: %target-build-swift -emit-module-path %t/main.swiftmodule -module-name main %s %S/Inputs/SR8045-other.swift
+
+public class Sub: Super {
+  public override func foo(_ f: @escaping Alias<Bool>) {}
+}