Skip to content

Commit e25d4a8

Browse files
Always install make tool and always pass it to CMake
1 parent d9ee0ee commit e25d4a8

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

utils/build.ps1

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,12 @@ $msbuild = "$VSInstallRoot\MSBuild\Current\Bin\$BuildArchName\MSBuild.exe"
175175
# Avoid $env:ProgramFiles in case this script is running as x86
176176
$UnixToolsBinDir = "$env:SystemDrive\Program Files\Git\usr\bin"
177177

178+
# The make tool isn't part of MSYS, but we need it for LLDB tests
179+
$MakeToolPath = "C:/Program Files (x86)/GnuWin32/bin/make.exe"
180+
if (-not (Test-Path $MakeToolPath)) {
181+
& winget install GnuWin32.Make
182+
}
183+
178184
$python = "${env:ProgramFiles(x86)}\Microsoft Visual Studio\Shared\Python39_64\python.exe"
179185
if (-not (Test-Path $python)) {
180186
$python = (where.exe python) | Select-Object -First 1
@@ -1364,12 +1370,6 @@ function Build-Compilers() {
13641370
& $python -m pip install psutil
13651371
& $python -m pip install packaging
13661372

1367-
# Install make tool from GunWin32
1368-
$MakeToolPath = "C:/Program Files (x86)/GnuWin32/bin/make.exe"
1369-
if (-not (Test-Path $MakeToolPath)) {
1370-
& winget install GnuWin32.Make
1371-
}
1372-
13731373
# Transitive dependency if _lldb.pyd: CMake cannot copy it, because it
13741374
# doesn't exist during the initial build.
13751375
$RuntimeBinaryCache = Get-TargetProjectBinaryCache $Arch Runtime
@@ -1383,8 +1383,6 @@ function Build-Compilers() {
13831383
LLVM_ENABLE_PROJECTS = "clang;clang-tools-extra;lld;lldb";
13841384
# No watchpoint support on windows: https://github.com/llvm/llvm-project/issues/24820
13851385
LLDB_TEST_USER_ARGS = "--skip-category=watchpoint";
1386-
# TODO: winget install GnuWin32.Make
1387-
LLDB_TEST_MAKE = $MakeToolPath
13881386
# gtest sharding breaks llvm-lit's --xfail and LIT_XFAIL inputs: https://github.com/llvm/llvm-project/issues/102264
13891387
LLVM_LIT_ARGS = "-v --no-gtest-sharding --show-xfail --show-unsupported";
13901388
# LLDB Unit tests link against this library
@@ -1429,6 +1427,7 @@ function Build-Compilers() {
14291427
LLDB_PYTHON_EXT_SUFFIX = ".pyd";
14301428
LLDB_PYTHON_RELATIVE_PATH = "lib/site-packages";
14311429
LLDB_TABLEGEN = (Join-Path -Path $BuildTools -ChildPath "lldb-tblgen.exe");
1430+
LLDB_TEST_MAKE = $MakeToolPath;
14321431
LLVM_CONFIG_PATH = (Join-Path -Path $BuildTools -ChildPath "llvm-config.exe");
14331432
LLVM_EXTERNAL_SWIFT_SOURCE_DIR = "$SourceCache\swift";
14341433
LLVM_NATIVE_TOOL_DIR = $BuildTools;

0 commit comments

Comments
 (0)