Skip to content

Commit e2a7dd0

Browse files
authored
Merge pull request #32052 from CodaFi/is-uniquely-referenced
[NFC] Remove Extra Deduplication of External Depends
2 parents 0cab1ce + 4e6b68f commit e2a7dd0

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

lib/Frontend/ModuleInterfaceBuilder.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
#include "swift/AST/DiagnosticsSema.h"
2020
#include "swift/AST/FileSystem.h"
2121
#include "swift/AST/Module.h"
22-
#include "llvm/ADT/StringSet.h"
2322
#include "swift/Basic/Defer.h"
2423
#include "swift/Frontend/Frontend.h"
2524
#include "swift/Frontend/ModuleInterfaceSupport.h"
@@ -28,7 +27,6 @@
2827
#include "clang/Frontend/CompilerInstance.h"
2928
#include "clang/Lex/PreprocessorOptions.h"
3029
#include "llvm/ADT/Hashing.h"
31-
#include "llvm/ADT/StringSet.h"
3230
#include "llvm/Support/xxhash.h"
3331
#include "llvm/Support/Debug.h"
3432
#include "llvm/Support/CommandLine.h"
@@ -85,7 +83,6 @@ bool ModuleInterfaceBuilder::collectDepsForSerialization(
8583
InitialDepNames.push_back(interfacePath);
8684
InitialDepNames.insert(InitialDepNames.end(),
8785
extraDependencies.begin(), extraDependencies.end());
88-
llvm::StringSet<> AllDepNames;
8986
SmallString<128> Scratch;
9087

9188
for (const auto &InitialDepName : InitialDepNames) {
@@ -104,7 +101,7 @@ bool ModuleInterfaceBuilder::collectDepsForSerialization(
104101
if (!prebuiltCachePath.empty() && DepName.startswith(prebuiltCachePath))
105102
continue;
106103

107-
if (AllDepNames.insert(DepName).second && dependencyTracker) {
104+
if (dependencyTracker) {
108105
dependencyTracker->addDependency(DepName, /*isSystem*/IsSDKRelative);
109106
}
110107

0 commit comments

Comments
 (0)