[Macros] Ensure that we visit *all* members when emitting memberwise initializer

Fixes rdar://111122261.

Author: DougGregor

lib/IRGen/GenDecl.cpp

@@ -5662,7 +5662,7 @@ static bool shouldEmitCategory(IRGenModule &IGM, ExtensionDecl *ext) {
       return true;
   }
 
-  for (auto member : ext->getMembers()) {
+  for (auto member : ext->getAllMembers()) {
     if (auto func = dyn_cast<FuncDecl>(member)) {
       if (requiresObjCMethodDescriptor(func))
         return true;

lib/SILGen/SILGen.cpp

@@ -1509,7 +1509,7 @@ static bool requiresIVarInitialization(SILGenModule &SGM, ClassDecl *cd) {
   if (!cd->requiresStoredPropertyInits())
     return false;
 
-  for (Decl *member : cd->getImplementationContext()->getMembers()) {
+  for (Decl *member : cd->getImplementationContext()->getAllMembers()) {
     auto pbd = dyn_cast<PatternBindingDecl>(member);
     if (!pbd) continue;
 
@@ -1522,7 +1522,7 @@ static bool requiresIVarInitialization(SILGenModule &SGM, ClassDecl *cd) {
 }
 
 bool SILGenModule::hasNonTrivialIVars(ClassDecl *cd) {
-  for (Decl *member : cd->getImplementationContext()->getMembers()) {
+  for (Decl *member : cd->getImplementationContext()->getAllMembers()) {
     auto *vd = dyn_cast<VarDecl>(member);
     if (!vd || !vd->hasStorage()) continue;
 

lib/SILGen/SILGenConstructor.cpp

@@ -1469,7 +1469,7 @@ void SILGenFunction::emitMemberInitializers(DeclContext *dc,
                                             NominalTypeDecl *nominal) {
   auto subs = getSubstitutionsForPropertyInitializer(dc, nominal);
 
-  for (auto member : nominal->getImplementationContext()->getMembers()) {
+  for (auto member : nominal->getImplementationContext()->getAllMembers()) {
     // Find instance pattern binding declarations that have initializers.
     if (auto pbd = dyn_cast<PatternBindingDecl>(member)) {
       if (pbd->isStatic()) continue;

test/Macros/Inputs/syntax_macro_definitions.swift

@@ -1604,6 +1604,21 @@ extension SelfAlwaysEqualOperator: MemberMacro {
   }
 }
 
+public struct AddPeerStoredPropertyMacro: PeerMacro, Sendable {
+  public static func expansion(
+    of attribute: AttributeSyntax,
+    providingPeersOf declaration: some DeclSyntaxProtocol,
+    in context: some MacroExpansionContext
+  ) throws -> [DeclSyntax] {
+    return [
+      """
+
+      private var _foo: Int = 100
+      """
+    ]
+  }
+}
+
 public struct InitializableMacro: ConformanceMacro, MemberMacro {
   public static func expansion(
     of node: AttributeSyntax,

test/Macros/macro_expand_peers.swift

@@ -213,3 +213,19 @@ func testVarPeer() {
   _ = value
   _ = Date().value
 }
+
+// Stored properties added via peer macros.
+@attached(peer, names: named(_foo))
+macro AddPeerStoredProperty() =
+  #externalMacro(module: "MacroDefinition", type: "AddPeerStoredPropertyMacro")
+
+struct SomeStructWithPeerProperties {
+  @AddPeerStoredProperty
+
+  func foo() {}
+}
+
+func testStructWithPeers() {
+  let x = SomeStructWithPeerProperties()
+  print(x)
+}