[AST/Unittest] Don't swallow a const qualifier.

dcci · dcci · commit e30b1f510103 · 2017-09-11T18:04:43.000-07:00
I found this by inspection (also, I found that newer
clang versions also warns for this under -Wall). While here,
convert to static_cast&lt;&gt; for a more idiomatic C++.
diff --git a/unittests/AST/SourceLocTests.cpp b/unittests/AST/SourceLocTests.cpp
@@ -23,7 +23,8 @@ namespace swift {
   void PrintTo(SourceLoc loc, std::ostream *os) {
     *os << loc.getOpaquePointerValue();
     if (loc.isValid())
-      *os << " '" << *(char *)loc.getOpaquePointerValue() << "'";
+      *os << " '" << *static_cast<const char *>(loc.getOpaquePointerValue())
+          << "'";
   }
 
   void PrintTo(SourceRange range, std::ostream *os) {

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,8 @@ namespace swift {`
`23`	`23`	`void PrintTo(SourceLoc loc, std::ostream *os) {`
`24`	`24`	`*os << loc.getOpaquePointerValue();`
`25`	`25`	`if (loc.isValid())`
`26`		`- os << " '" << (char *)loc.getOpaquePointerValue() << "'";`
	`26`	`+ os << " '" << static_cast<const char *>(loc.getOpaquePointerValue())`
	`27`	`+ << "'";`
`27`	`28`	`}`
`28`	`29`
`29`	`30`	`void PrintTo(SourceRange range, std::ostream *os) {`