Skip to content

Commit e36247d

Browse files
GankraAlexis Beingessner
authored andcommitted
block collection reflections tests on a stable collection ABI
1 parent 0f85c88 commit e36247d

File tree

5 files changed

+14
-5
lines changed

5 files changed

+14
-5
lines changed

validation-test/Reflection/reflect_Array.swift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
// REQUIRES: objc_interop
55
// REQUIRES: executable_test
66

7+
// FIXME(ABI): This test is too fragile while this type isn't ABI stable
8+
// REQUIRES: rdar29139967
9+
710
import SwiftReflectionTest
811

912
class TestClass {

validation-test/Reflection/reflect_Dictionary.swift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
// REQUIRES: objc_interop
55
// REQUIRES: executable_test
66

7+
// FIXME(ABI): This test is too fragile while this type isn't ABI stable
8+
// REQUIRES: rdar29139967
9+
710
import SwiftReflectionTest
811

912
class TestClass {

validation-test/Reflection/reflect_Set.swift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
// REQUIRES: objc_interop
55
// REQUIRES: executable_test
66

7+
// FIXME(ABI): This test is too fragile while this type isn't ABI stable
8+
// REQUIRES: rdar29139967
9+
710
import SwiftReflectionTest
811

912
class TestClass {

validation-test/Reflection/reflect_String.swift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
// REQUIRES: objc_interop
55
// REQUIRES: executable_test
66

7+
// FIXME(ABI): This test is too fragile while this type isn't ABI stable
8+
// REQUIRES: rdar29139967
9+
710
import SwiftReflectionTest
811

912
class TestClass {

validation-test/Reflection/reflect_multiple_types.swift

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,8 @@
44
// REQUIRES: objc_interop
55
// REQUIRES: executable_test
66

7-
// FIXME: Test failing in CI for simulator
8-
// REQUIRES: OS=macosx
9-
10-
// FIXME: https://bugs.swift.org/browse/SR-2808
11-
// XFAIL: resilient_stdlib
7+
// FIXME(ABI): This test is too fragile while these type aren't ABI stable
8+
// REQUIRES: rdar29139967
129

1310
import SwiftReflectionTest
1411
import Foundation

0 commit comments

Comments
 (0)