Don't use previously found owned concrete values in OSSA.

Author: meg-gupta

lib/SILOptimizer/SILCombiner/SILCombinerApplyVisitors.cpp

@@ -789,7 +789,12 @@ SILCombiner::buildConcreteOpenedExistentialInfoFromSoleConformingType(
   ConcreteExistentialInfo &SoleCEI = *COAI.CEI;
   assert(SoleCEI.isValid());
 
-  if (SoleCEI.ConcreteValue)
+  // In ossa, don not use the concrete value previously found as it maybe
+  // forward consumed and not available at the apply using the opened
+  // existential.
+  if (SoleCEI.ConcreteValue &&
+      (!F->hasOwnership() ||
+       SoleCEI.ConcreteValue->getOwnershipKind() != OwnershipKind::Owned))
     return COAI;
 
   // Create SIL type for the concrete type.

test/SILOptimizer/sil_combine_concrete_existential_ossa.swift

@@ -2845,17 +2845,32 @@ bb0(%0 : @owned $Klass):
   return %3 : $Builtin.NativeObject
 }
 
-// CHECK-LABEL: sil [ossa] @collapse_existential_pack_unpack_unchecked_ref_cast_owned3 :
-// CHECK-NOT:     init_existential_ref
-// CHECK-NOT:     open_existential_ref
-// CHECK: } // end sil function 'collapse_existential_pack_unpack_unchecked_ref_cast_owned3'
-sil [ossa] @collapse_existential_pack_unpack_unchecked_ref_cast_owned3 : $@convention(thin) (@owned Klass) -> @owned Builtin.NativeObject {
+// CHECK-LABEL: sil [ossa] @collapse_existential_pack_unpack_unchecked_ref_cast_owned3_fail :
+// CHECK:     init_existential_ref
+// CHECK:     open_existential_ref
+// CHECK: } // end sil function 'collapse_existential_pack_unpack_unchecked_ref_cast_owned3_fail'
+sil [ossa] @collapse_existential_pack_unpack_unchecked_ref_cast_owned3_fail : $@convention(thin) (@owned Klass) -> @owned Builtin.NativeObject {
 bb0(%0 : @owned $Klass):
   %1 = init_existential_ref %0 : $Klass : $Klass, $AnyObject
   %2 = open_existential_ref %1 : $AnyObject to $@opened("7CAE06CE-5F10-11E4-AF13-C82A1428F987", AnyObject) Self
   %f = function_ref @use_generic_obj_guaranteed : $@convention(thin) <τ_0_0> (@guaranteed τ_0_0) -> ()
   apply %f<@opened("7CAE06CE-5F10-11E4-AF13-C82A1428F987", AnyObject) Self>(%2) : $@convention(thin) <τ_0_0> (@guaranteed τ_0_0) -> ()
+  %3 = unchecked_ref_cast %2 : $@opened("7CAE06CE-5F10-11E4-AF13-C82A1428F987", AnyObject) Self to $Builtin.NativeObject
+  return %3 : $Builtin.NativeObject
+}
 
+// CHECK-LABEL: sil [ossa] @collapse_existential_pack_unpack_unchecked_ref_cast_owned4_fail :
+// CHECK:     init_existential_ref
+// CHECK:     open_existential_ref
+// CHECK: } // end sil function 'collapse_existential_pack_unpack_unchecked_ref_cast_owned4_fail'
+sil [ossa] @collapse_existential_pack_unpack_unchecked_ref_cast_owned4_fail : $@convention(thin) (@owned Klass) -> @owned Builtin.NativeObject {
+bb0(%0 : @owned $Klass):
+  %1 = init_existential_ref %0 : $Klass : $Klass, $AnyObject
+  %f1 = function_ref @use_anyobject_guaranteed : $@convention(thin) (@guaranteed AnyObject) -> ()
+  apply %f1(%1) : $@convention(thin) (@guaranteed AnyObject) -> ()
+  %2 = open_existential_ref %1 : $AnyObject to $@opened("7CAE06CE-5F10-11E4-AF13-C82A1428F987", AnyObject) Self
+  %f2 = function_ref @use_generic_obj_guaranteed : $@convention(thin) <τ_0_0> (@guaranteed τ_0_0) -> ()
+  apply %f2<@opened("7CAE06CE-5F10-11E4-AF13-C82A1428F987", AnyObject) Self>(%2) : $@convention(thin) <τ_0_0> (@guaranteed τ_0_0) -> ()
   %3 = unchecked_ref_cast %2 : $@opened("7CAE06CE-5F10-11E4-AF13-C82A1428F987", AnyObject) Self to $Builtin.NativeObject
   return %3 : $Builtin.NativeObject
 }