Skip to content

Commit e4d84d5

Browse files
committed
fix: add missing whitespace in TODO comment
1 parent b9598b2 commit e4d84d5

File tree

9 files changed

+19
-19
lines changed

9 files changed

+19
-19
lines changed

stdlib/include/llvm/ADT/iterator_range.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,11 @@ class iterator_range {
3232
IteratorT begin_iterator, end_iterator;
3333

3434
public:
35-
//TODO: Add SFINAE to test that the Container's iterators match the range's
35+
// TODO: Add SFINAE to test that the Container's iterators match the range's
3636
// iterators.
3737
template <typename Container>
3838
iterator_range(Container &&c)
39-
//TODO: Consider ADL/non-member begin/end calls.
39+
// TODO: Consider ADL/non-member begin/end calls.
4040
: begin_iterator(c.begin()), end_iterator(c.end()) {}
4141
iterator_range(IteratorT begin_iterator, IteratorT end_iterator)
4242
: begin_iterator(std::move(begin_iterator)),

stdlib/public/core/StringBridge.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,7 @@ internal func _bridgeTaggedASCII(
358358

359359
@_effects(readonly)
360360
private func _NSStringASCIIPointer(_ str: _StringSelectorHolder) -> UnsafePointer<UInt8>? {
361-
//TODO(String bridging): Unconditionally asking for nul-terminated contents is
361+
// TODO(String bridging): Unconditionally asking for nul-terminated contents is
362362
// overly conservative and hurts perf with some NSStrings
363363
return str._fastCStringContents(1)?._asUInt8
364364
}

stdlib/public/core/SwiftNativeNSArray.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -165,22 +165,22 @@ extension __SwiftNativeNSArrayWithContiguousStorage {
165165
@objc(objectAtIndexedSubscript:)
166166
@_effects(readonly)
167167
dynamic internal func objectAtSubscript(_ index: Int) -> Unmanaged<AnyObject> {
168-
//TODO: exception instead of precondition, once that's possible
168+
// TODO: exception instead of precondition, once that's possible
169169
return Unmanaged.passUnretained(contents[index])
170170
}
171171

172172
@objc(objectAtIndex:)
173173
@_effects(readonly)
174174
dynamic internal func objectAt(_ index: Int) -> Unmanaged<AnyObject> {
175-
//TODO: exception instead of precondition, once that's possible
175+
// TODO: exception instead of precondition, once that's possible
176176
return Unmanaged.passUnretained(contents[index])
177177
}
178178

179179
@objc internal func getObjects(
180180
_ aBuffer: UnsafeMutablePointer<AnyObject>, range: _SwiftNSRange
181181
) {
182182
return contents.withContiguousStorageIfAvailable { objects in
183-
//TODO: exceptions instead of preconditions, once that's possible
183+
// TODO: exceptions instead of preconditions, once that's possible
184184

185185
_precondition(
186186
_isValidArrayIndex(range.location, count: objects.count),

test/Interop/Cxx/static/static-member-var-silgen.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ func writeSelfMember(_ m: WithIncompleteStaticMember) {
4747
// CHECK: [[ADDR:%.*]] = global_addr @{{_ZN26WithIncompleteStaticMember10selfMemberE|\?selfMember@WithIncompleteStaticMember@@2V1@A}} : $*WithIncompleteStaticMember
4848
// CHECK: [[ACCESS:%.*]] = begin_access [modify] [dynamic] [[ADDR]] : $*WithIncompleteStaticMember
4949
// CHECK: store %0 to [[ACCESS]] : $*WithIncompleteStaticMember
50-
//TODO fix undefined reference to `WithConstStaticMember::notDefined`.
50+
// TODO: fix undefined reference to `WithConstStaticMember::notDefined`.
5151
// func readNotDefinedConstMember() -> CInt {
5252
// return WithConstStaticMember.notDefined
5353
// }
@@ -61,4 +61,4 @@ func readDefinedConstMember() -> CInt {
6161
// CHECK: return [[VALUE]] : $Int32
6262
func readDefinedOutOfLineConstMember() -> CInt {
6363
return WithConstStaticMember.definedOutOfLine
64-
}
64+
}

test/Interop/Cxx/static/static-member-var.swift

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ StaticMemberVarTestSuite.test("write-static-member-from-swift") {
3030
}
3131

3232
StaticMemberVarTestSuite.test("incomplete-array-static-member") {
33-
//TODO recognize array member variable `arrayMember`.
33+
// TODO: recognize array member variable `arrayMember`.
3434
// expectEqual(18, WithIncompleteStaticMember.arrayMember[0])
3535
// expectEqual(3, WithIncompleteStaticMember.arrayMember.count)
3636
}
@@ -56,28 +56,28 @@ StaticMemberVarTestSuite.test("write-incomplete-self-static-member-from-swift")
5656
}
5757

5858
StaticMemberVarTestSuite.test("const-static-member") {
59-
//TODO fix undefined reference to `WithConstStaticMember::notDefined`.
59+
// TODO: fix undefined reference to `WithConstStaticMember::notDefined`.
6060
// expectEqual(24, WithConstStaticMember.notDefined)
6161
expectEqual(48, WithConstStaticMember.defined)
6262
expectEqual(96, WithConstStaticMember.definedOutOfLine)
6363
}
6464

6565
StaticMemberVarTestSuite.test("const-static-member") {
66-
//TODO fix undefined reference to `WithConstStaticMember::notDefined`.
66+
// TODO: fix undefined reference to `WithConstStaticMember::notDefined`.
6767
// expectEqual(24, WithConstStaticMember.notDefined)
6868
expectEqual(48, WithConstStaticMember.defined)
6969
expectEqual(96, WithConstStaticMember.definedOutOfLine)
7070
}
7171

7272
StaticMemberVarTestSuite.test("const-static-member") {
73-
//TODO fix undefined reference to `WithConstStaticMember::notDefined`.
73+
// TODO: fix undefined reference to `WithConstStaticMember::notDefined`.
7474
// expectEqual(24, WithConstStaticMember.notDefined)
7575
expectEqual(48, WithConstStaticMember.defined)
7676
expectEqual(96, WithConstStaticMember.definedOutOfLine)
7777
}
7878

7979
StaticMemberVarTestSuite.test("const-static-member") {
80-
//TODO fix undefined reference to `WithConstStaticMember::notDefined`.
80+
// TODO: fix undefined reference to `WithConstStaticMember::notDefined`.
8181
// expectEqual(WithConstStaticMember.notDefined)
8282
expectEqual(48, WithConstStaticMember.defined)
8383
expectEqual(96, WithConstStaticMember.definedOutOfLine)

test/Interop/Cxx/templates/dependent-types.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,20 +98,20 @@ DependentTypesTestSuite.test("Complex different dependent argument and return ty
9898
expectEqual(m2, 42)
9999
}
100100

101-
//TODO: Import issue: rdar://89028943
101+
// TODO: Import issue: rdar://89028943
102102
// DependentTypesTestSuite.test("Dependent to Reference") {
103103
// var x = 42
104104
// let m = dependentToRef(x) as! M<Int>
105105
// expectEqual(m.getValue(), 42)
106106
// }
107107

108-
//TODO: Not imported: rdar://89034440
108+
// TODO: Not imported: rdar://89034440
109109
// DependentTypesTestSuite.test("Dependent Reference.") {
110110
// let m = dependentRef()
111111
// expectEqual(m.getValue(), 42)
112112
// }
113113

114-
//TODO: Not imported: rdar://89034440
114+
// TODO: Not imported: rdar://89034440
115115
// DependentTypesTestSuite.test("Dependent reference and reference inferred") {
116116
// let m = dependentRefAndRefInferred(M<Int>(value: 40), 2) as! M<Int>
117117
// expectEqual(m.getValue(), 42)

validation-test/Reflection/reflect_nested_generic.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ reflect(enum: Outer1.C<Void>.Inner.S<(Int,Int)>?.none)
6565
//X64-NEXT: (case name=none index=1)))))
6666
//X64-NEXT: (case name=none index=1))
6767

68-
//TODO: Work out the layout for 32-bit targets
68+
// TODO: Work out the layout for 32-bit targets
6969

7070
//CHECK: Mangled name: $s22reflect_nested_generic6Outer1O1CC1SVy_yt_Si_SitGSg
7171
//CHECK-NEXT: Demangled name: Swift.Optional<reflect_nested_generic.Outer1.C<()>.S<(Swift.Int, Swift.Int)>>

validation-test/compiler_crashers_2_fixed/0072-issue-46480-1.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ class MyController: TiViewController<MyPresenter, MyView>, MyView { // ERROR: 'T
7171
}
7272

7373
internal func setDataItems(_: [String]) {
74-
//TODO
74+
// TODO
7575
}
7676
}
7777

validation-test/compiler_crashers_2_fixed/0072-issue-46480-2.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ class MyController: TiViewController<MyPresenter, MyView>, MyView {
6666
}
6767

6868
internal func setDataItems(_: [String]) {
69-
//TODO
69+
// TODO
7070
}
7171
}
7272

0 commit comments

Comments
 (0)