[stdlib/private][os log] Annotate tiny helper functions in the new

os log overlay @_transparent so that they will be inlined in their
callers even annotated as @_optimize(none).

Make the OSLogPrototypeCompileTest.swift test suite check only the
output of the OSLogOptimization pass instead of the output of the
Onone pipeline. This will make the tes more resilient to adding
mandatory optimizations later in the pass pipeline. Also, remove
a duplicate test from the OSLogPrototypeExecTest suite.

Author: ravikandhadai

stdlib/private/OSLog/OSLogIntegerTypes.swift

@@ -58,6 +58,17 @@ extension OSLogInterpolation {
     appendInteger(number, format: format, privacy: privacy)
   }
 
+  @_semantics("constant_evaluable")
+  @inlinable
+  @_optimize(none)
+  public mutating func appendInterpolation(
+    _ number: @autoclosure @escaping () -> UInt,
+    format: IntFormat = .decimal,
+    privacy: Privacy = .public
+  ) {
+    appendInteger(number, format: format, privacy: privacy)
+  }
+
   /// Given an integer, create and append a format specifier for the integer to the
   /// format string property. Also, append the integer along with necessary headers
   /// to the OSLogArguments property.
@@ -154,10 +165,11 @@ extension OSLogArguments {
 }
 
 /// Return the number of bytes needed for serializing an integer argument as
-/// specified by os_log. This function must be constant evaluable.
-@_semantics("constant_evaluable")
-@inlinable
-@_optimize(none)
+/// specified by os_log. This function must be constant evaluable. Note that
+/// it is marked transparent instead of @inline(__always) as it is used in
+/// optimize(none) functions.
+@_transparent
+@usableFromInline
 internal func sizeForEncoding<T>(
   _ type: T.Type
 ) -> Int where T : FixedWidthInteger  {

stdlib/private/OSLog/OSLogMessage.swift

@@ -48,9 +48,10 @@ public enum Privacy {
 @_optimize(none)
 public var maxOSLogArgumentCount: UInt8 { return 48 }
 
-@_semantics("constant_evaluable")
-@inlinable
-@_optimize(none)
+/// Note that this is marked transparent instead of @inline(__always) as it is
+/// used in optimize(none) functions.
+@_transparent
+@usableFromInline
 internal var logBitsPerByte: Int { return 3 }
 
 /// Represents a string interpolation passed to the log APIs.

stdlib/private/OSLog/OSLogStringTypes.swift

@@ -101,10 +101,10 @@ extension OSLogArguments {
 /// bitWidth property, and since MemoryLayout is not supported by the constant
 /// evaluator, this function returns the byte size of Int, which must equal the
 /// word length of the target architecture and hence the pointer size.
-/// This function must be constant evaluable.
-@_semantics("constant_evaluable")
-@inlinable
-@_optimize(none)
+/// This function must be constant evaluable. Note that it is marked transparent
+/// instead of @inline(__always) as it is used in optimize(none) functions.
+@_transparent
+@usableFromInline
 internal func pointerSizeInBytes() -> Int {
   return Int.bitWidth &>> logBitsPerByte
 }