Merge pull request #67172 from JTurcotti/sil-pass

Add SIL Pass for flow-sensitive, region-based Sendable checking

Author: Joshua Turcotti

include/swift/AST/DiagnosticsSIL.def

@@ -856,5 +856,12 @@ NOTE(sil_referencebinding_inout_binding_here, none,
       "inout binding here",
       ())
 
+// Warnings arising from the flow-sensitive checking of Sendability of
+// non-Sendable values
+WARNING(consumed_value_used, none,
+        "Non-Sendable value consumed, then used at this site; could yield race with another thread", ())
+WARNING(arg_region_consumed, none,
+        "This application could pass `self` or a Non-Sendable argument of this function to another thread, potentially yielding a race with the caller", ())
+
 #define UNDEFINE_DIAGNOSTIC_MACROS
 #include "DefineDiagnosticMacros.h"

include/swift/AST/Expr.h

@@ -4649,7 +4649,7 @@ struct ApplyIsolationCrossing {
 
   // Whether to use the isolation of the caller or callee for generating
   // informative diagnostics depends on whether this crossing is an exit.
-  // In particular, we tend to use the caller isolation for diagnostics,
+  // In particular, we tend to use the callee isolation for diagnostics,
   // but if this crossing is an exit from isolation then the callee isolation
   // is not very informative, so we use the caller isolation instead.
   ActorIsolation getDiagnoseIsolation() const {