reproduce deinit not running

Author: ktoso

test/Distributed/Inputs/FakeDistributedActorSystems.swift

@@ -226,6 +226,10 @@ public final class FakeRoundtripActorSystem: DistributedActorSystem, @unchecked
 
   public init() {}
 
+  public func shutdown() {
+    self.activeActors = [:]
+  }
+
   public func resolve<Act>(id: ActorID, as actorType: Act.Type)
     throws -> Act? where Act: DistributedActor {
     print("| resolve \(id) as remote // this system always resolves as remote")
@@ -394,7 +398,14 @@ public struct FakeInvocationEncoder : DistributedTargetInvocationEncoder {
     print(" > done recording")
   }
 
-  public func makeDecoder() -> FakeInvocationDecoder {
+  public mutating func makeDecoder() -> FakeInvocationDecoder {
+    defer {
+      // reset the decoder; we don't want to keep these values retained by accident here
+      genericSubs = []
+      arguments = []
+      returnType = nil
+      errorType = nil
+    }
     return .init(
       args: arguments,
       substitutions: genericSubs,
@@ -406,32 +417,13 @@ public struct FakeInvocationEncoder : DistributedTargetInvocationEncoder {
 
 // === decoding --------------------------------------------------------------
 
-class Guardian {
-  let type: String
-  let file: String
-  let line: UInt
-
-  init(_ type: any Any.Type, file: String = #fileID, line: UInt = #line) {
-    self.type = "\(type)"
-    self.file = file
-    self.line = line
-    print("init Guardian(\(type)) @ \(file):\(line)")
-  }
-
-  deinit {
-    print("deinit Guardian(\(type)) @ \(file):\(line)")
-  }
-}
-
 // !!! WARNING !!!
 // This is a 'final class' on purpose, to see that we retain the ad-hoc witness
 // for 'decodeNextArgument'; Do not change it to just a class!
 @available(SwiftStdlib 5.7, *)
 public final class FakeInvocationDecoder: DistributedTargetInvocationDecoder {
   public typealias SerializationRequirement = Codable
 
-  let x = Guardian(FakeInvocationDecoder.self)
-
   var genericSubs: [Any.Type] = []
   var arguments: [Any] = []
   var returnType: Any.Type? = nil
@@ -466,8 +458,6 @@ public final class FakeInvocationDecoder: DistributedTargetInvocationDecoder {
       fatalError("Cannot cast argument\(anyArgument) to expected \(Argument.self)")
     }
 
-    arguments = []
-
     print("  > decode argument: \(argument)")
     argumentIndex += 1
     return argument

test/Distributed/Runtime/distributed_actor_func_calls_decoded_args_deinit.swift

@@ -21,11 +21,15 @@ import FakeDistributedActorSystems
 typealias DefaultDistributedActorSystem = FakeRoundtripActorSystem
 
 final class SomeClass<T>: Sendable, Codable {
-  init() {
-    print("SomeClass: init")
+  let file: String
+  let line: UInt
+  init(file: String = #fileID, line: UInt = #line) {
+    self.file = file
+    self.line = line
+    print("SomeClass: init @ \(file):\(line)")
   }
   deinit {
-    print("SomeClass: deinit")
+    print("SomeClass: deinit @ \(file):\(line)")
   }
 }
 
@@ -40,15 +44,16 @@ distributed actor Greeter {
 
 func test() async throws {
   let system = DefaultDistributedActorSystem()
+  defer { system.shutdown() }
 
   let local = Greeter(actorSystem: system)
   let ref = try Greeter.resolve(id: local.id, using: system)
 
-  try await ref.test1(SomeClass<Int>())
-  // CHECK: SomeClass: init
-  // CHECK: SomeClass: deinit
-
-//  try await ref.test2(S(data: SomeClass<Int>()))
+  var value = SomeClass<Int>()
+  try await ref.test1(value)
+  print("RETAIN COUNT: \(_swift_retainCount(value))")
+  _swift_release(value) // FIXME: we're missing a release!
+  print("RETAIN COUNT: \(_swift_retainCount(value))")
   // CHECK: SomeClass: init
   // CHECK: SomeClass: deinit
 }
@@ -58,3 +63,8 @@ func test() async throws {
     try! await test()
   }
 }
+
+@_silgen_name("swift_release")
+func _swift_release(_: AnyObject)
+@_silgen_name("swift_retainCount")
+func _swift_retainCount(_: AnyObject) -> Int