Skip to content

Commit e9b8e61

Browse files
committed
Address review comments by MForster.
1 parent 4627431 commit e9b8e61

File tree

3 files changed

+1
-5
lines changed

3 files changed

+1
-5
lines changed

lib/Driver/DarwinToolChains.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -713,7 +713,7 @@ toolchains::Darwin::constructInvocation(const DynamicLinkJobAction &job,
713713
Arguments.push_back(context.Args.MakeArgString(getTriple().getArchName()));
714714

715715
if (context.cxxInteropEnabled()) {
716-
// We only support libc++ on Darwin.
716+
// On Darwin, we only support libc++.
717717
Arguments.push_back("-lc++");
718718
}
719719

lib/Driver/UnixToolChains.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,8 +182,6 @@ toolchains::GenericUnix::constructInvocation(const DynamicLinkJobAction &job,
182182

183183
// Configure the toolchain.
184184
//
185-
// We use `clang++` if C++ interop is enabled, `clang` otherwise.
186-
//
187185
// We don't use `clang++` unconditionally because we want to avoid pulling in
188186
// a C++ standard library if it's not needed, in particular because the
189187
// standard library that `clang++` selects by default may not be the one that

lib/Driver/WindowsToolChains.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,6 @@ toolchains::Windows::constructInvocation(const DynamicLinkJobAction &job,
8585
}
8686

8787
// Configure the toolchain.
88-
//
89-
// We use `clang++` if C++ interop is enabled, `clang` otherwise.
9088
const char *Clang = context.cxxInteropEnabled()? "clang++" : "clang";
9189
if (const Arg *A = context.Args.getLastArg(options::OPT_tools_directory)) {
9290
StringRef toolchainPath(A->getValue());

0 commit comments

Comments
 (0)