Sema: Fix quadratic checkFunctionErrorHandling() in WMO mode

slavapestov · slavapestov · commit ec42da0ba735 · 2018-04-06T00:54:22.000-07:00
diff --git a/lib/Sema/TypeChecker.cpp b/lib/Sema/TypeChecker.cpp
@@ -460,6 +460,7 @@ static void typeCheckFunctionsAndExternalDecls(SourceFile &SF, TypeChecker &TC)
 
       if (auto *AFD = dyn_cast<AbstractFunctionDecl>(decl)) {
         TC.typeCheckAbstractFunctionBody(AFD);
+        TC.checkFunctionErrorHandling(AFD);
         continue;
       }
       if (isa<NominalTypeDecl>(decl)) {
@@ -559,11 +560,6 @@ static void typeCheckFunctionsAndExternalDecls(SourceFile &SF, TypeChecker &TC)
   for (AbstractFunctionDecl *FD : TC.definedFunctions) {
     TC.checkFunctionErrorHandling(FD);
   }
-  for (auto decl : TC.Context.ExternalDefinitions) {
-    if (auto fn = dyn_cast<AbstractFunctionDecl>(decl)) {
-      TC.checkFunctionErrorHandling(fn);
-    }
-  }
 }
 
 void swift::typeCheckExternalDefinitions(SourceFile &SF) {

Original file line number	Diff line number	Diff line change
`@@ -460,6 +460,7 @@ static void typeCheckFunctionsAndExternalDecls(SourceFile &SF, TypeChecker &TC)`
`460`	`460`
`461`	`461`	`if (auto *AFD = dyn_cast<AbstractFunctionDecl>(decl)) {`
`462`	`462`	`TC.typeCheckAbstractFunctionBody(AFD);`
	`463`	`+ TC.checkFunctionErrorHandling(AFD);`
`463`	`464`	`continue;`
`464`	`465`	`}`
`465`	`466`	`if (isa<NominalTypeDecl>(decl)) {`
`@@ -559,11 +560,6 @@ static void typeCheckFunctionsAndExternalDecls(SourceFile &SF, TypeChecker &TC)`
`559`	`560`	`for (AbstractFunctionDecl *FD : TC.definedFunctions) {`
`560`	`561`	`TC.checkFunctionErrorHandling(FD);`
`561`	`562`	`}`
`562`		`- for (auto decl : TC.Context.ExternalDefinitions) {`
`563`		`- if (auto fn = dyn_cast<AbstractFunctionDecl>(decl)) {`
`564`		`- TC.checkFunctionErrorHandling(fn);`
`565`		`- }`
`566`		`- }`
`567`	`563`	`}`
`568`	`564`
`569`	`565`	`void swift::typeCheckExternalDefinitions(SourceFile &SF) {`