Merge pull request #7666 from practicalswift/gardening-20170221

[gardening] Remove asserts from fixed crashers. Fix URLs. Fix word processing artefacts. Cleanups.

Author: practicalswift

docs/OwnershipManifesto.md

@@ -797,7 +797,7 @@ additional semantic concerns.
 A shared value can be used in the scope that binds it
 just like an ordinary parameter or `let` binding.
 If the shared value is used in a place that requires
-ownership, Swift will simply implicitly copy the value —
+ownership, Swift will simply implicitly copy the value --
 again, just like an ordinary parameter or `let` binding.
 
 #### Limitations of shared values
@@ -861,7 +861,7 @@ born from a trio of concerns:
   lexical and maintains the ability to run arbitrary code
   at the end of an access.  Imagine what it would take to
   implement a loop that added these temporary mutable
-  references to an array — each iteration of the loop would
+  references to an array -- each iteration of the loop would
   have to be able to queue up arbitrary code to run as a clean-up
   when the function was finished with the array.  This would
   hardly be a low-cost abstraction!  A more Rust-like

include/swift/Basic/OwnedString.h

@@ -5,8 +5,8 @@
 // Copyright (c) 2014 - 2016 Apple Inc. and the Swift project authors
 // Licensed under Apache License v2.0 with Runtime Library Exception
 //
-// See http://swift.org/LICENSE.txt for license information
-// See http://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
+// See https://swift.org/LICENSE.txt for license information
+// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 //
 //===----------------------------------------------------------------------===//
 //

include/swift/Runtime/Config.h

@@ -17,8 +17,6 @@
 #ifndef SWIFT_RUNTIME_CONFIG_H
 #define SWIFT_RUNTIME_CONFIG_H
 
-#include "llvm/Support/Compiler.h"
-
 /// Does the current Swift platform support "unbridged" interoperation
 /// with Objective-C?  If so, the implementations of various types must
 /// implicitly handle Objective-C pointers.

include/swift/Syntax/TokenSyntax.h

@@ -5,8 +5,8 @@
 // Copyright (c) 2014 - 2017 Apple Inc. and the Swift project authors
 // Licensed under Apache License v2.0 with Runtime Library Exception
 //
-// See http://swift.org/LICENSE.txt for license information
-// See http://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
+// See https://swift.org/LICENSE.txt for license information
+// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 //
 //===----------------------------------------------------------------------===//
 //

include/swift/Syntax/Trivia.h

@@ -5,8 +5,8 @@
 // Copyright (c) 2014 - 2017 Apple Inc. and the Swift project authors
 // Licensed under Apache License v2.0 with Runtime Library Exception
 //
-// See http://swift.org/LICENSE.txt for license information
-// See http://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
+// See https://swift.org/LICENSE.txt for license information
+// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 //
 //===----------------------------------------------------------------------===//
 //

include/swift/Syntax/TypeSyntax.h

@@ -56,7 +56,7 @@ class BalancedTokensSyntaxData final : public SyntaxData {
 #pragma mark balanced-tokens API
 
 /// balanced-tokens -> Any identifier, keyword, literal, or operator
-///                  | Any punctuation except (­, )­, [­, ]­, {­, or }­
+///                  | Any punctuation except (, ), [, ], {, or }
 class BalancedTokensSyntax final : public Syntax {
   friend struct SyntaxFactory;
   friend class SyntaxData;
@@ -229,16 +229,16 @@ class TypeSyntaxData : public SyntaxData {
 #pragma mark -
 #pragma mark type-syntax API
 
-/// type -> array-type­
-///       | dictionary-type­
-///       | function-type­
-///       | type-identifier­
-///       | tuple-type­
-///       | optional-type­
-///       | implicitly-unwrapped-optional-type­
-///       | protocol-composition-type­
-///       | metatype-type­
-///       | 'Any­'
+/// type -> array-type
+///       | dictionary-type
+///       | function-type
+///       | type-identifier
+///       | tuple-type
+///       | optional-type
+///       | implicitly-unwrapped-optional-type
+///       | protocol-composition-type
+///       | metatype-type
+///       | 'Any'
 ///       | 'Self'
 class TypeSyntax : public Syntax {
   using DataType = TypeSyntaxData;

lib/SILGen/SILGenConvert.cpp

@@ -677,7 +677,7 @@ ManagedValue SILGenFunction::emitExistentialErasure(
     if (!C.getEmitInto() && !silConv.useLoweredAddresses()) {
       // We should never create new buffers just for init_existential under
       // opaque values mode: This is a case of an opaque value that we can
-      // “treat” as a by-value one
+      // "treat" as a by-value one
       ManagedValue sub = F(SGFContext());
       SILValue v = B.createInitExistentialOpaque(
           loc, existentialTL.getLoweredType(), concreteFormalType,

lib/Sema/Semantics.cpp

@@ -1,3 +1,15 @@
+//===--- Semantics.cpp - Semantics manager --------------------------------===//
+//
+// This source file is part of the Swift.org open source project
+//
+// Copyright (c) 2014 - 2017 Apple Inc. and the Swift project authors
+// Licensed under Apache License v2.0 with Runtime Library Exception
+//
+// See https://swift.org/LICENSE.txt for license information
+// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
+//
+//===----------------------------------------------------------------------===//
+
 #include "swift/Sema/Semantics.h"
 #include "swift/AST/Expr.h"
 #include "swift/AST/Decl.h"

lib/Syntax/LegacyASTTransformer.cpp

@@ -286,7 +286,8 @@ LegacyASTTransformer::visitStructDecl(StructDecl *D,
                                       const CursorIndex IndexInParent) {
   return getUnknownDecl(D);
 
-/* TODO
+// TODO
+#if 0
   StructDeclSyntaxBuilder StructBuilder;
   if (D->getStartLoc().isValid()) {
     auto StructKeyword = findTokenSyntax(tok::kw_struct, "struct", SourceMgr,
@@ -332,7 +333,7 @@ LegacyASTTransformer::visitStructDecl(StructDecl *D,
   StructBuilder.useMembers(MemberBuilder.build());
 
   return StructBuilder.build().Root;
-*/
+#endif
 }
 
 RC<SyntaxData>

utils/rusage.py

@@ -133,5 +133,5 @@ def __call__(self, parser, namespace, v, option_string=None):
                      % args.time)
 
 if over_mem or over_time:
-    exit(-1)
-exit(ret)
+    sys.exit(-1)
+sys.exit(ret)

validation-test/BuildSystem/LTO/target-libraries-do-not-have-bitcode.test-sh

@@ -23,9 +23,12 @@ function check_thin_archive_for_bitcode() {
     local BASE_TEMPDIR=$1
     local ARCHIVE=$2
 
-    local LIB_NAME=$(basename ${ARCHIVE})
-    local LIB_ARCH=$(basename $(dirname ${ARCHIVE}))
-    local LIB_PLATFORM=$(basename $(dirname $(dirname ${ARCHIVE})))
+    local LIB_NAME
+    LIB_NAME=$(basename ${ARCHIVE})
+    local LIB_ARCH
+    LIB_ARCH=$(basename $(dirname ${ARCHIVE}))
+    local LIB_PLATFORM
+    LIB_PLATFORM=$(basename $(dirname $(dirname ${ARCHIVE})))
 
     LIB_TEMP_DIR="${BASE_TEMPDIR}/${LIB_PLATFORM}-${LIB_ARCH}-${LIB_NAME}"
     mkdir -p "${LIB_TEMP_DIR}"
@@ -52,8 +55,10 @@ function check_thick_archive_for_bitcode() {
     local BASE_TEMPDIR=$1
     local ARCHIVE=$2
 
-    local LIB_NAME=$(basename ${ARCHIVE})
-    local LIB_PLATFORM=$(basename $(dirname ${ARCHIVE}))
+    local LIB_NAME
+    LIB_NAME=$(basename ${ARCHIVE})
+    local LIB_PLATFORM
+    LIB_PLATFORM=$(basename $(dirname ${ARCHIVE}))
 
     LIB_TEMP_DIR="${BASE_TEMPDIR}/${LIB_PLATFORM}-thick-${LIB_NAME}"
     LIB_ARCHIVE_DIR="${LIB_TEMP_DIR}/archive"

validation-test/compiler_crashers_fixed/28599-false-should-have-found-context-by-now.swift

@@ -6,5 +6,4 @@
 // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 
 // RUN: not %target-swift-frontend %s -emit-ir
-// REQUIRES: asserts
 protocol a:A{{}class d{func b(a=}}protocol A:a{{}class a

validation-test/compiler_crashers_fixed/28604-isinheritedprotocolsvalid.swift

@@ -6,6 +6,5 @@
 // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 
 // RUN: not %target-swift-frontend %s -emit-ir
-// REQUIRES: asserts
 protocol a:b
 protocol b:Range<a>