Skip to content

Commit ed30b9f

Browse files
committed
[build-script] Fix issue with DOTEST_ARGS for LLDB.
LLDB expects the DOTEST_ARGS CMake variable to be a list with entries separated by semicolons. (cherry picked from commit 1544a47)
1 parent b497780 commit ed30b9f

File tree

1 file changed

+15
-13
lines changed

1 file changed

+15
-13
lines changed

utils/build-script-impl

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2464,14 +2464,6 @@ for host in "${ALL_HOSTS[@]}"; do
24642464
cmake_cache="Apple-lldb-Linux.cmake"
24652465
fi
24662466

2467-
# Watchpoint testing is currently disabled: see rdar://38566150.
2468-
LLDB_TEST_CATEGORIES="--skip-category=watchpoint"
2469-
2470-
# Skip DWO to speed up swift testing.
2471-
if [[ "$(true_false ${LLDB_TEST_SWIFT_ONLY})" == "TRUE" ]]; then
2472-
LLDB_TEST_CATEGORIES="${LLDB_TEST_CATEGORIES} --skip-category=dwo"
2473-
fi
2474-
24752467
# Options to find the just-built libddispatch and Foundation.
24762468
if [[ "$(uname -s)" == "Darwin" || "${SKIP_BUILD_FOUNDATION}" ]] ; then
24772469
DOTEST_EXTRA=""
@@ -2491,11 +2483,21 @@ for host in "${ALL_HOSTS[@]}"; do
24912483
DOTEST_EXTRA="${DOTEST_EXTRA} -Xlinker -rpath -Xlinker ${FOUNDATION_BUILD_DIR}"
24922484
fi
24932485

2494-
# Construct dotest arguments.
2495-
DOTEST_ARGS="--build-dir ${lldb_build_dir}/lldb-test-build.noindex \
2496-
${LLDB_TEST_CATEGORIES} \
2497-
-t \
2498-
-E \"${DOTEST_EXTRA}\""
2486+
# Watchpoint testing is currently disabled: see rdar://38566150.
2487+
LLDB_TEST_CATEGORIES="--skip-category=watchpoint"
2488+
2489+
# Skip DWO to speed up swift testing.
2490+
if [[ "$(true_false ${LLDB_TEST_SWIFT_ONLY})" == "TRUE" ]]; then
2491+
LLDB_TEST_CATEGORIES="${LLDB_TEST_CATEGORIES};--skip-category=dwo"
2492+
fi
2493+
2494+
# Construct dotest arguments. We use semicolons so CMake interprets this as a list.
2495+
DOTEST_ARGS="--build-dir;${lldb_build_dir}/lldb-test-build.noindex;${LLDB_TEST_CATEGORIES};-t"
2496+
2497+
# Only set the extra arguments if they're not empty.
2498+
if [[ -z "${results_targets[@]}" ]]; then
2499+
DOTEST_ARGS="${DOTEST_ARGS};-E;\"${DOTEST_EXTRA}\""
2500+
fi
24992501

25002502
cmake_options=(
25012503
"${cmake_options[@]}"

0 commit comments

Comments
 (0)