Gardening: Migrate test suite to GH issues: decl/func

Author: AnthonyLatsis

test/decl/func/default-values-swift4.swift

@@ -93,7 +93,7 @@ public func publicFunctionWithDefaultValue(
     y: Int = internalIntFunction()) {}
     // expected-error@-1 {{global function 'internalIntFunction()' is internal and cannot be referenced from a default argument value}}
 
-// https://bugs.swift.org/browse/SR-5559
+// https://github.com/apple/swift/issues/48131
 public class MyClass {
   public func method<T>(_: T.Type = T.self) -> T { }
 }

test/decl/func/default-values.swift

@@ -123,7 +123,7 @@ struct X<T> {
 let testXa: X<Int> = .foo(i: 0)
 let testXb: X<Int> = .bar
 
-// SR-10062
+// https://github.com/apple/swift/issues/52464
 
 var aLiteral = 1
 let bLiteral = 2
@@ -175,16 +175,21 @@ let fooThing5 = Foo(a: 0, d: 1, h: nil) // expected-error {{missing arguments fo
 let fooThing6 = Foo(a: 0, d: 1, e: 2, h: nil) // expected-error {{missing argument for parameter 'f' in call}}
                                               // expected-note@-29 {{'init(a:b:d:e:f:g:h:)' declared here}}
 
-// SR-11085
-func sr_11085(x: Int) {}
-func sr_11085(line: String = #line) {} // expected-error {{default argument value of type 'Int' cannot be converted to type 'String'}}
-sr_11085()
+// https://github.com/apple/swift/issues/53477
+  do {
+  func f(x: Int) {}
+  func f(line: String = #line) {} // expected-error {{default argument value of type 'Int' cannot be converted to type 'String'}}
+  f()
 
-class SR_11085_C { init(line: String = #line) {} } // expected-error {{default argument value of type 'Int' cannot be converted to type 'String'}}
-let _ = SR_11085_C()
+  class C { init(line: String = #line) {} } // expected-error {{default argument value of type 'Int' cannot be converted to type 'String'}}
+  let _ = C()
+}
+
+// https://github.com/apple/swift/issues/54034
 
-// SR-11623
-func badGenericMagicLiteral<T : ExpressibleByIntegerLiteral>(_ x: T = #function) -> T { x } // expected-error {{default argument value of type 'String' cannot be converted to type 'T'}}
+// FIXME: Bad diagnostic
+// expected-error@+1 {{default argument value of type 'String' cannot be converted to type 'T'}}
+func badGenericMagicLiteral<T : ExpressibleByIntegerLiteral>(_ x: T = #function) -> T { x }
 let _: Int = badGenericMagicLiteral()
 
 func genericMagicLiteral<T : ExpressibleByIntegerLiteral>(_ x: T = #line) -> T { x } // expected-note {{where 'T' = 'String'}}

test/decl/func/functions.swift

@@ -181,7 +181,7 @@ func parentheticalInout2(_ fn: (((inout Int)), Int) -> ()) {
   fn(&value, 0)
 }
 
-// SR-11724
+// https://github.com/apple/swift/issues/54133
 // FIXME: None of these diagnostics is particularly good.
 func bogusDestructuring() {
   struct Bar {}

test/decl/func/rethrows.swift

@@ -536,7 +536,7 @@ func testDoRethrow() {
   DoRethrowGeneric<Int>().method(fn:) { (a, b) in return a }
 }
 
-// https://bugs.swift.org/browse/SR-7120 - capture lists
+// https://github.com/apple/swift/issues/49668
 func rethrowsWithCaptureList<R, T>(
   array: [T],
   operation: (Int) throws -> R
@@ -553,10 +553,10 @@ public func rdar40472018() {
 }
 
 
-// https://bugs.swift.org/browse/SR-6299
+// https://github.com/apple/swift/issues/48849
 // Verify that we do not emit an invalid
 //   "... can throw but the expression is not marked with 'try'"
-// error on the use of the operators.
+// error on the use of operators.
 
 infix operator <|: infixr0
 infix operator |>: infixl1
@@ -613,12 +613,16 @@ func rdar_47550715() {
   func bar(_: A<F>? = .none) {} // Ok
 }
 
-// SR-14270 - test case for diagnostic note 'because_rethrows_default_argument_throws'
+// https://github.com/apple/swift/issues/56630
+// Test cases for diagnostic note 'because_rethrows_default_argument_throws'
+
 func nonThrowableDefaultRethrows(_ f: () throws -> () = {}) rethrows {
   try f()
 }
-// NOTE: This should compile and not emit a diagnostic because ideally the compiler could statically
-// know the default argument value could never throw. See SR-1524.
+
+// FIXME: This should compile and not emit a diagnostic because ideally the
+// compiler could statically know the default argument value could never throw.
+// (https://github.com/apple/swift/issues/44143)
 nonThrowableDefaultRethrows() // expected-error {{call can throw but is not marked with 'try'}}
                               // expected-note@-1 {{call is to 'rethrows' function, but a defaulted argument function can throw}}
 

test/decl/func/throwing_functions_without_try.swift

@@ -52,14 +52,14 @@ func baz2() -> Int {
   return x
 }
 
-// SR-11016
+// https://github.com/apple/swift/issues/53406
 
-protocol SR_11016_P {
+protocol P_53406 {
   func bar() throws
 }
 
-class SR_11016_C {
-  var foo: SR_11016_P?
+class C_53406 {
+  var foo: P_53406?
 
   func someMethod() throws {
     foo?.bar() // expected-error {{call can throw but is not marked with 'try'}}

test/decl/func/trailing_closures.swift

@@ -1,5 +1,6 @@
 // RUN: %target-typecheck-verify-swift
 
-// SR-4205: Don't warn about non-trailing closures followed by parameters with
+// https://github.com/apple/swift/issues/46788
+// Don't warn about non-trailing closures followed by parameters with
 // default arguments.
 func f1(_ f: () -> (), bar: Int = 10) { } // no-warning