Skip to content

Commit ee12fd6

Browse files
committed
NCGenerics: reenable round-trip for mangling
1 parent 70266b5 commit ee12fd6

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

lib/Frontend/CompilerInvocation.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2641,9 +2641,6 @@ static bool ParseIRGenArgs(IRGenOptions &Opts, ArgList &Args,
26412641
if (Args.hasArg(OPT_no_clang_module_breadcrumbs))
26422642
Opts.DisableClangModuleSkeletonCUs = true;
26432643

2644-
if (SWIFT_ENABLE_EXPERIMENTAL_NONCOPYABLE_GENERICS)
2645-
Opts.DisableRoundTripDebugTypes = true; // temporary until we fix mangling!
2646-
26472644
if (auto A = Args.getLastArg(OPT_enable_round_trip_debug_types,
26482645
OPT_disable_round_trip_debug_types)) {
26492646
Opts.DisableRoundTripDebugTypes =

lib/IRGen/IRGenDebugInfo.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1817,6 +1817,10 @@ class IRGenDebugInfoImpl : public IRGenDebugInfo {
18171817
// Emit the protocols the archetypes conform to.
18181818
SmallVector<llvm::Metadata *, 4> Protocols;
18191819
for (auto *ProtocolDecl : Archetype->getConformsTo()) {
1820+
// Skip marker protocols, as they are not available at runtime.
1821+
if (ProtocolDecl->isMarkerProtocol())
1822+
continue;
1823+
18201824
auto PTy =
18211825
IGM.getLoweredType(ProtocolDecl->getInterfaceType()).getASTType();
18221826
auto PDbgTy = DebugTypeInfo::getFromTypeInfo(

stdlib/cmake/modules/SwiftSource.cmake

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -610,7 +610,6 @@ function(_compile_swift_files
610610
if(SWIFT_ENABLE_EXPERIMENTAL_NONCOPYABLE_GENERICS)
611611
list(APPEND swift_flags "-enable-experimental-feature" "NoncopyableGenerics")
612612
list(APPEND swift_flags "-Xfrontend" "-enable-experimental-associated-type-inference")
613-
list(APPEND swift_flags "-Xfrontend" "-disable-round-trip-debug-types") # NOTE: temporary until we fix mangling!
614613
endif()
615614

616615
if (SWIFT_STDLIB_ENABLE_STRICT_CONCURRENCY_COMPLETE)

0 commit comments

Comments
 (0)