Skip to content

Commit eecfb6e

Browse files
committed
[stdlib] Renamed cross-platform C helper functions in Darwin so that we can share them with Glibc.
1 parent d875a56 commit eecfb6e

File tree

3 files changed

+42
-40
lines changed

3 files changed

+42
-40
lines changed

stdlib/public/Platform/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ add_swift_library(swiftDarwin IS_SDK_OVERLAY
22
Darwin.swift
33
POSIXError.swift
44
MachError.swift
5-
Misc.mm
5+
Misc.c
66
tgmath.swift.gyb
77
SWIFT_COMPILE_FLAGS -Xfrontend -disable-objc-attr-requires-foundation-module
88
API_NOTES_NON_OVERLAY)

stdlib/public/Platform/Darwin.swift

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -146,16 +146,16 @@ public var stderr : UnsafeMutablePointer<FILE> {
146146
//===----------------------------------------------------------------------===//
147147

148148
@warn_unused_result
149-
@_silgen_name("_swift_Darwin_open")
150-
func _swift_Darwin_open(
149+
@_silgen_name("_swift_Platform_open")
150+
func _swift_Platform_open(
151151
path: UnsafePointer<CChar>,
152152
_ oflag: CInt,
153153
_ mode: mode_t
154154
) -> CInt
155155

156156
@warn_unused_result
157-
@_silgen_name("_swift_Darwin_openat")
158-
func _swift_Darwin_openat(fd: CInt,
157+
@_silgen_name("_swift_Platform_openat")
158+
func _swift_Platform_openat(fd: CInt,
159159
_ path: UnsafePointer<CChar>,
160160
_ oflag: CInt,
161161
_ mode: mode_t
@@ -166,7 +166,7 @@ public func open(
166166
path: UnsafePointer<CChar>,
167167
_ oflag: CInt
168168
) -> CInt {
169-
return _swift_Darwin_open(path, oflag, 0)
169+
return _swift_Platform_open(path, oflag, 0)
170170
}
171171

172172
@warn_unused_result
@@ -175,7 +175,7 @@ public func open(
175175
_ oflag: CInt,
176176
_ mode: mode_t
177177
) -> CInt {
178-
return _swift_Darwin_open(path, oflag, mode)
178+
return _swift_Platform_open(path, oflag, mode)
179179
}
180180

181181
@warn_unused_result
@@ -184,7 +184,7 @@ public func openat(
184184
_ path: UnsafePointer<CChar>,
185185
_ oflag: CInt
186186
) -> CInt {
187-
return _swift_Darwin_openat(fd, path, oflag, 0)
187+
return _swift_Platform_openat(fd, path, oflag, 0)
188188
}
189189

190190
@warn_unused_result
@@ -194,20 +194,20 @@ public func openat(
194194
_ oflag: CInt,
195195
_ mode: mode_t
196196
) -> CInt {
197-
return _swift_Darwin_openat(fd, path, oflag, mode)
197+
return _swift_Platform_openat(fd, path, oflag, mode)
198198
}
199199

200200
@warn_unused_result
201-
@_silgen_name("_swift_Darwin_fcntl")
202-
internal func _swift_Darwin_fcntl(
201+
@_silgen_name("_swift_Platform_fcntl")
202+
internal func _swift_Platform_fcntl(
203203
fd: CInt,
204204
_ cmd: CInt,
205205
_ value: CInt
206206
) -> CInt
207207

208208
@warn_unused_result
209-
@_silgen_name("_swift_Darwin_fcntlPtr")
210-
internal func _swift_Darwin_fcntlPtr(
209+
@_silgen_name("_swift_Platform_fcntlPtr")
210+
internal func _swift_Platform_fcntlPtr(
211211
fd: CInt,
212212
_ cmd: CInt,
213213
_ ptr: UnsafeMutablePointer<Void>
@@ -218,7 +218,7 @@ public func fcntl(
218218
fd: CInt,
219219
_ cmd: CInt
220220
) -> CInt {
221-
return _swift_Darwin_fcntl(fd, cmd, 0)
221+
return _swift_Platform_fcntl(fd, cmd, 0)
222222
}
223223

224224
@warn_unused_result
@@ -227,7 +227,7 @@ public func fcntl(
227227
_ cmd: CInt,
228228
_ value: CInt
229229
) -> CInt {
230-
return _swift_Darwin_fcntl(fd, cmd, value)
230+
return _swift_Platform_fcntl(fd, cmd, value)
231231
}
232232

233233
@warn_unused_result
@@ -236,7 +236,7 @@ public func fcntl(
236236
_ cmd: CInt,
237237
_ ptr: UnsafeMutablePointer<Void>
238238
) -> CInt {
239-
return _swift_Darwin_fcntlPtr(fd, cmd, ptr)
239+
return _swift_Platform_fcntlPtr(fd, cmd, ptr)
240240
}
241241

242242
public var S_IFMT: mode_t { return mode_t(0o170000) }
@@ -315,15 +315,15 @@ public var SEM_FAILED: UnsafeMutablePointer<sem_t> {
315315
}
316316

317317
@warn_unused_result
318-
@_silgen_name("_swift_Darwin_sem_open2")
319-
internal func _swift_Darwin_sem_open2(
318+
@_silgen_name("_swift_Platform_sem_open2")
319+
internal func _swift_Platform_sem_open2(
320320
name: UnsafePointer<CChar>,
321321
_ oflag: CInt
322322
) -> UnsafeMutablePointer<sem_t>
323323

324324
@warn_unused_result
325-
@_silgen_name("_swift_Darwin_sem_open4")
326-
internal func _swift_Darwin_sem_open4(
325+
@_silgen_name("_swift_Platform_sem_open4")
326+
internal func _swift_Platform_sem_open4(
327327
name: UnsafePointer<CChar>,
328328
_ oflag: CInt,
329329
_ mode: mode_t,
@@ -335,7 +335,7 @@ public func sem_open(
335335
name: UnsafePointer<CChar>,
336336
_ oflag: CInt
337337
) -> UnsafeMutablePointer<sem_t> {
338-
return _swift_Darwin_sem_open2(name, oflag)
338+
return _swift_Platform_sem_open2(name, oflag)
339339
}
340340

341341
@warn_unused_result
@@ -345,6 +345,6 @@ public func sem_open(
345345
_ mode: mode_t,
346346
_ value: CUnsignedInt
347347
) -> UnsafeMutablePointer<sem_t> {
348-
return _swift_Darwin_sem_open4(name, oflag, mode, value)
348+
return _swift_Platform_sem_open4(name, oflag, mode, value)
349349
}
350350

Lines changed: 20 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
//===--- Misc.mm - Darwin overlay helpers ---------------------------------===//
1+
//===--- Misc.c - Darwin overlay helpers ----------------------------------===//
22
//
33
// This source file is part of the Swift.org open source project
44
//
@@ -13,49 +13,51 @@
1313
#include <fcntl.h>
1414
#include <semaphore.h>
1515

16-
#define _REENTRANT
17-
#include <math.h>
18-
19-
extern "C" int
20-
_swift_Darwin_open(const char *path, int oflag, mode_t mode) {
16+
extern int
17+
_swift_Platform_open(const char *path, int oflag, mode_t mode) {
2118
return open(path, oflag, mode);
2219
}
2320

24-
extern "C" int
25-
_swift_Darwin_openat(int fd, const char *path, int oflag, mode_t mode) {
21+
extern int
22+
_swift_Platform_openat(int fd, const char *path, int oflag, mode_t mode) {
2623
return openat(fd, path, oflag, mode);
2724
}
2825

29-
extern "C" sem_t *_swift_Darwin_sem_open2(const char *name, int oflag) {
26+
extern sem_t *_swift_Platform_sem_open2(const char *name, int oflag) {
3027
return sem_open(name, oflag);
3128
}
3229

33-
extern "C" sem_t *_swift_Darwin_sem_open4(const char *name, int oflag,
34-
mode_t mode, unsigned int value) {
30+
extern sem_t *_swift_Platform_sem_open4(const char *name, int oflag,
31+
mode_t mode, unsigned int value) {
3532
return sem_open(name, oflag, mode, value);
3633
}
3734

38-
extern "C" int
39-
_swift_Darwin_fcntl(int fd, int cmd, int value) {
35+
extern int
36+
_swift_Platform_fcntl(int fd, int cmd, int value) {
4037
return fcntl(fd, cmd, value);
4138
}
4239

43-
extern "C" int
44-
_swift_Darwin_fcntlPtr(int fd, int cmd, void* ptr) {
40+
extern int
41+
_swift_Platform_fcntlPtr(int fd, int cmd, void* ptr) {
4542
return fcntl(fd, cmd, ptr);
4643
}
4744

48-
extern "C" float
45+
#if defined(__APPLE__)
46+
#define _REENTRANT
47+
#include <math.h>
48+
49+
extern float
4950
_swift_Darwin_lgammaf_r(float x, int *psigngam) {
5051
return lgammaf_r(x, psigngam);
5152
}
5253

53-
extern "C" double
54+
extern double
5455
_swift_Darwin_lgamma_r(double x, int *psigngam) {
5556
return lgamma_r(x, psigngam);
5657
}
5758

58-
extern "C" long double
59+
extern long double
5960
_swift_Darwin_lgammal_r(long double x, int *psigngam) {
6061
return lgammal_r(x, psigngam);
6162
}
63+
#endif

0 commit comments

Comments
 (0)