Mangler: enable mangling verification also in non-assert compiler builds

eeckstein · eeckstein · commit ef6cedcdb7d6 · 2024-10-21T12:31:43.000+02:00
Not verifying mangled names can result in crashes later in the optimizer in case of mangling errors.

Related to rdar://137298914
diff --git a/lib/Basic/Mangler.cpp b/lib/Basic/Mangler.cpp
@@ -159,7 +159,6 @@ static bool treeContains(Demangle::NodePointer Nd, Demangle::Node::Kind Kind) {
 }
 
 void Mangler::verify(StringRef nameStr) {
-#ifndef NDEBUG
   SmallString<128> buffer;
   if (!nameStr.starts_with(MANGLING_PREFIX_STR) &&
       !nameStr.starts_with("_Tt") &&
@@ -191,7 +190,6 @@ void Mangler::verify(StringRef nameStr) {
                   "original     = " << nameStr << "\n"
                   "remangled    = " << Remangled << "\n";
   abort();
-#endif
 }
 
 void Mangler::appendIdentifier(StringRef ident) {

Original file line number	Diff line number	Diff line change
`@@ -159,7 +159,6 @@ static bool treeContains(Demangle::NodePointer Nd, Demangle::Node::Kind Kind) {`
`159`	`159`	`}`
`160`	`160`
`161`	`161`	`void Mangler::verify(StringRef nameStr) {`
`162`		`-#ifndef NDEBUG`
`163`	`162`	`SmallString<128> buffer;`
`164`	`163`	`if (!nameStr.starts_with(MANGLING_PREFIX_STR) &&`
`165`	`164`	`!nameStr.starts_with("_Tt") &&`
`@@ -191,7 +190,6 @@ void Mangler::verify(StringRef nameStr) {`
`191`	`190`	`"original = " << nameStr << "\n"`
`192`	`191`	`"remangled = " << Remangled << "\n";`
`193`	`192`	`abort();`
`194`		`-#endif`
`195`	`193`	`}`
`196`	`194`
`197`	`195`	`void Mangler::appendIdentifier(StringRef ident) {`