Skip to content

Commit f0974bd

Browse files
committed
[Backtracing] Turn off MemberImportVisibility.
Also fixed a couple of other minor issues preventing this PR from building on its own. rdar://137201928
1 parent 9329776 commit f0974bd

File tree

4 files changed

+12
-5
lines changed

4 files changed

+12
-5
lines changed

stdlib/public/Backtracing/CMakeLists.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,8 @@ set(BACKTRACING_COMPILE_FLAGS
5353
"-Xfrontend;-experimental-spi-only-imports"
5454
"-Xcc;-I${SWIFT_SOURCE_DIR}/include"
5555
"-Xcc;-I${CMAKE_BINARY_DIR}/include"
56-
"-Xcc;-I${SWIFT_STDLIB_SOURCE_DIR}/public/Backtracing/modules")
56+
"-Xcc;-I${SWIFT_STDLIB_SOURCE_DIR}/public/Backtracing/modules"
57+
"-disable-upcoming-feature;MemberImportVisibility")
5758

5859
###TODO: Add these when we add static linking support
5960
#

stdlib/public/Backtracing/Elf.swift

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ let EI_VERSION = swift.runtime.EI_VERSION
7575
let EI_OSABI = swift.runtime.EI_OSABI
7676
let EI_ABIVERSION = swift.runtime.EI_ABIVERSION
7777
let EI_PAD = swift.runtime.EI_PAD
78+
let EI_NIDENT = BacktracingImpl.EI_NIDENT
7879

7980
let ELFMAG0 = swift.runtime.ELFMAG0
8081
let ELFMAG1 = swift.runtime.ELFMAG1
@@ -181,6 +182,12 @@ let DF_TEXTREL = swift.runtime.DF_TEXTREL
181182
let DF_BIND_NOW = swift.runtime.DF_BIND_NOW
182183
let DF_STATIC_TLS = swift.runtime.DF_STATIC_TLS
183184

185+
let NT_GNU_ABI_TAG = swift.runtime.NT_GNU_ABI_TAG
186+
let NT_GNU_HWCAP = swift.runtime.NT_GNU_HWCAP
187+
let NT_GNU_BUILD_ID = swift.runtime.NT_GNU_BUILD_ID
188+
let NT_GNU_GOLD_VERSION = swift.runtime.NT_GNU_GOLD_VERSION
189+
let NT_GNU_PROPERTY_TYPE_0 = swift.runtime.NT_GNU_PROPERTY_TYPE_0
190+
184191
typealias Elf32_Ehdr = swift.runtime.Elf32_Ehdr
185192
typealias Elf64_Ehdr = swift.runtime.Elf64_Ehdr
186193

@@ -1365,7 +1372,7 @@ class ElfImage<SomeImageSource: ImageSource,
13651372
}
13661373

13671374
for note in notes {
1368-
if note.name == "GNU" && note.type == ImageFormats.NT_GNU_BUILD_ID {
1375+
if note.name == "GNU" && note.type == NT_GNU_BUILD_ID {
13691376
_uuid = note.desc
13701377
return _uuid
13711378
}

stdlib/public/libexec/swift-backtrace/CMakeLists.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@ set(BACKTRACING_COMPILE_FLAGS
2727
"-cxx-interoperability-mode=default"
2828
"-I${SWIFT_STDLIB_SOURCE_DIR}/public/Backtracing/modules"
2929
"-Xcc;-I${SWIFT_SOURCE_DIR}/include"
30-
"-Xcc;-I${CMAKE_BINARY_DIR}/include")
30+
"-Xcc;-I${CMAKE_BINARY_DIR}/include"
31+
"-disable-upcoming-feature;MemberImportVisibility")
3132

3233
set(BACKTRACING_SOURCES
3334
main.swift

stdlib/public/libexec/swift-backtrace/TargetLinux.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@ import _Backtracing
2929
@_spi(MemoryReaders) import _Backtracing
3030
@_spi(Utils) import _Backtracing
3131

32-
internal import Runtime
33-
3432
enum SomeBacktrace {
3533
case raw(Backtrace)
3634
case symbolicated(SymbolicatedBacktrace)

0 commit comments

Comments
 (0)