Merge pull request #73215 from slavapestov/capture-fix-and-cleanup

Fix regression from CaptureInfoRequest

Author: slavapestov

include/swift/AST/AnyFunctionRef.h

@@ -75,13 +75,6 @@ class AnyFunctionRef {
     return TheFunction.get<AbstractClosureExpr *>()->getCaptureInfo();
   }
 
-  void setCaptureInfo(CaptureInfo captures) const {
-    if (auto *AFD = TheFunction.dyn_cast<AbstractFunctionDecl *>()) {
-      AFD->setCaptureInfo(captures);
-      return;
-    }
-    TheFunction.get<AbstractClosureExpr *>()->setCaptureInfo(captures);
-  }
 
   bool hasType() const {
     if (auto *AFD = TheFunction.dyn_cast<AbstractFunctionDecl *>())

lib/AST/PackConformance.cpp

@@ -172,66 +172,6 @@ ProtocolConformanceRef PackConformance::subst(SubstitutionMap subMap,
   return subst(IFS);
 }
 
-namespace {
-
-struct PackConformanceExpander {
-  InFlightSubstitution &IFS;
-  ArrayRef<ProtocolConformanceRef> origConformances;
-
-public:
-  // Results built up by the expansion.
-  SmallVector<Type, 4> substElementTypes;
-  SmallVector<ProtocolConformanceRef, 4> substConformances;
-
-  PackConformanceExpander(InFlightSubstitution &IFS,
-                          ArrayRef<ProtocolConformanceRef> origConformances)
-    : IFS(IFS), origConformances(origConformances) {}
-
-private:
-  /// Substitute a scalar element of the original pack.
-  void substScalar(Type origElementType,
-                   ProtocolConformanceRef origConformance) {
-    auto substElementType = origElementType.subst(IFS);
-    auto substConformance = origConformance.subst(origElementType, IFS);
-
-    substElementTypes.push_back(substElementType);
-    substConformances.push_back(substConformance);
-  }
-
-  /// Substitute and expand an expansion element of the original pack.
-  void substExpansion(PackExpansionType *origExpansionType,
-                       ProtocolConformanceRef origConformance) {
-    IFS.expandPackExpansionType(origExpansionType,
-                                [&](Type substComponentType) {
-      auto origPatternType = origExpansionType->getPatternType();
-
-      // Just substitute the conformance.  We don't directly represent
-      // pack expansion conformances here; it's sort of implicit in the
-      // corresponding pack element type.
-      auto substConformance = origConformance.subst(origPatternType, IFS);
-
-      substElementTypes.push_back(substComponentType);
-      substConformances.push_back(substConformance);
-    });
-  }
-
-public:
-  void expand(PackType *origPackType) {
-    assert(origPackType->getNumElements() == origConformances.size());
-
-    for (auto i : range(origPackType->getNumElements())) {
-      auto origElementType = origPackType->getElementType(i);
-      if (auto *origExpansion = origElementType->getAs<PackExpansionType>()) {
-        substExpansion(origExpansion, origConformances[i]);
-      } else {
-        substScalar(origElementType, origConformances[i]);
-      }
-    }
-  }
-};
-
-} // end anonymous namespace
-
 ProtocolConformanceRef PackConformance::subst(TypeSubstitutionFn subs,
                                               LookupConformanceFn conformances,
                                               SubstOptions options) const {
@@ -241,14 +181,41 @@ ProtocolConformanceRef PackConformance::subst(TypeSubstitutionFn subs,
 
 ProtocolConformanceRef
 PackConformance::subst(InFlightSubstitution &IFS) const {
-  PackConformanceExpander expander(IFS, getPatternConformances());
-  expander.expand(ConformingType);
+  // Results built up by the expansion.
+  SmallVector<Type, 4> substElementTypes;
+  SmallVector<ProtocolConformanceRef, 4> substConformances;
+
+  auto origConformances = getPatternConformances();
+  assert(ConformingType->getNumElements() == origConformances.size());
+
+  for (auto i : range(ConformingType->getNumElements())) {
+    auto origElementType = ConformingType->getElementType(i);
+    if (auto *origExpansion = origElementType->getAs<PackExpansionType>()) {
+      // Substitute and expand an expansion element of the original pack.
+      IFS.expandPackExpansionType(origExpansion,
+                                  [&](Type substComponentType) {
+        substElementTypes.push_back(substComponentType);
+
+        // Just substitute the conformance.  We don't directly represent
+        // pack expansion conformances here; it's sort of implicit in the
+        // corresponding pack element type.
+        substConformances.push_back(
+            origConformances[i].subst(origExpansion->getPatternType(), IFS));
+      });
+    } else {
+      // Substitute a scalar element of the original pack.
+      substElementTypes.push_back(origElementType.subst(IFS));
+
+      substConformances.push_back(
+          origConformances[i].subst(origElementType, IFS));
+    }
+  }
 
   auto &ctx = Protocol->getASTContext();
-  auto *substConformingType = PackType::get(ctx, expander.substElementTypes);
+  auto *substConformingType = PackType::get(ctx, substElementTypes);
 
   auto substConformance = PackConformance::get(substConformingType, Protocol,
-                                               expander.substConformances);
+                                               substConformances);
   return ProtocolConformanceRef(substConformance);
 }
 

lib/Sema/TypeCheckCaptures.cpp

@@ -627,16 +627,16 @@ class FindCapturedVars : public ASTWalker {
 
 CaptureInfo CaptureInfoRequest::evaluate(Evaluator &evaluator,
                                          AbstractFunctionDecl *AFD) const {
-  BraceStmt *body = AFD->getTypecheckedBody();
-
   auto type = AFD->getInterfaceType();
-  if (type->is<ErrorType>() || body == nullptr)
+  if (type->is<ErrorType>())
     return CaptureInfo::empty();
 
   bool isNoEscape = type->castTo<AnyFunctionType>()->isNoEscape();
   FindCapturedVars finder(AFD->getLoc(), AFD, isNoEscape,
                           AFD->isObjC(), AFD->isGeneric());
-  body->walk(finder);
+
+  if (auto *body = AFD->getTypecheckedBody())
+    body->walk(finder);
 
   if (!AFD->isObjC()) {
     finder.checkType(type, AFD->getLoc());

test/SILGen/skip_local_function_bodies.swift

@@ -0,0 +1,16 @@
+// RUN: %empty-directory(%t)
+// RUN: %target-swift-frontend -emit-module -experimental-skip-non-inlinable-function-bodies-without-types %s -emit-module-path %t/skip_local_function_bodies.swiftmodule
+
+public protocol P {
+    init()
+}
+
+extension P {
+    public func f() {
+        typealias T = Self
+
+        func g(_ x: T) {}
+	g(self)
+    }
+}
+