[SourceKit] Return a default UID in getUIDForSyntaxNodeKind()

Nathan Hawes · Nathan Hawes · commit f23c24fe033e · 2019-07-23T11:14:14.000-07:00
Assert 0 and return a default kind, rather than calling unreachable
as a defensive fix for rdar://problem/53343735.
diff --git a/tools/SourceKit/lib/SwiftLang/SwiftLangSupport.cpp b/tools/SourceKit/lib/SwiftLang/SwiftLangSupport.cpp
@@ -467,7 +467,9 @@ UIdent SwiftLangSupport::getUIDForSyntaxNodeKind(SyntaxNodeKind SC) {
     return KindObjectLiteral;
   }
 
-  llvm_unreachable("Unhandled SyntaxNodeKind in switch.");
+  // Default to a known kind to prevent crashing in non-asserts builds
+  assert(0 && "Unhandled SyntaxNodeKind in switch.");
+  return KindIdentifier;
 }
 
 UIdent SwiftLangSupport::getUIDForSyntaxStructureKind(

Original file line number	Diff line number	Diff line change
`@@ -467,7 +467,9 @@ UIdent SwiftLangSupport::getUIDForSyntaxNodeKind(SyntaxNodeKind SC) {`
`467`	`467`	`return KindObjectLiteral;`
`468`	`468`	`}`
`469`	`469`
`470`		`- llvm_unreachable("Unhandled SyntaxNodeKind in switch.");`
	`470`	`+ // Default to a known kind to prevent crashing in non-asserts builds`
	`471`	`+ assert(0 && "Unhandled SyntaxNodeKind in switch.");`
	`472`	`+ return KindIdentifier;`
`471`	`473`	`}`
`472`	`474`
`473`	`475`	`UIdent SwiftLangSupport::getUIDForSyntaxStructureKind(`