JSONNodeDumper.cpp - VisitIntegerLiteral - avoid APSInt::toString std::string wrapper. NFCI

RKSimon · RKSimon · commit f3fd36e590f4 · 2021-06-09T11:09:32.000+01:00
Pulled out of D103888 - use the underlying SmallString version directly
diff --git a/clang/lib/AST/JSONNodeDumper.cpp b/clang/lib/AST/JSONNodeDumper.cpp
@@ -1414,9 +1414,10 @@ void JSONNodeDumper::VisitCXXDependentScopeMemberExpr(
 }
 
 void JSONNodeDumper::VisitIntegerLiteral(const IntegerLiteral *IL) {
-  JOS.attribute("value",
-                IL->getValue().toString(
-                    /*Radix=*/10, IL->getType()->isSignedIntegerType()));
+  llvm::SmallString<16> Buffer;
+  IL->getValue().toString(Buffer,
+                          /*Radix=*/10, IL->getType()->isSignedIntegerType());
+  JOS.attribute("value", Buffer);
 }
 void JSONNodeDumper::VisitCharacterLiteral(const CharacterLiteral *CL) {
   // FIXME: This should probably print the character literal as a string,

Original file line number	Diff line number	Diff line change
`@@ -1414,9 +1414,10 @@ void JSONNodeDumper::VisitCXXDependentScopeMemberExpr(`
`1414`	`1414`	`}`
`1415`	`1415`
`1416`	`1416`	`void JSONNodeDumper::VisitIntegerLiteral(const IntegerLiteral *IL) {`
`1417`		`- JOS.attribute("value",`
`1418`		`- IL->getValue().toString(`
`1419`		`- /Radix=/10, IL->getType()->isSignedIntegerType()));`
	`1417`	`+ llvm::SmallString<16> Buffer;`
	`1418`	`+ IL->getValue().toString(Buffer,`
	`1419`	`+ /Radix=/10, IL->getType()->isSignedIntegerType());`
	`1420`	`+ JOS.attribute("value", Buffer);`
`1420`	`1421`	`}`
`1421`	`1422`	`void JSONNodeDumper::VisitCharacterLiteral(const CharacterLiteral *CL) {`
`1422`	`1423`	`// FIXME: This should probably print the character literal as a string,`