[CSDiag] Adds a new diagnostic for implicit propertyWrapper initializer

Author: theblixguy

include/swift/AST/DiagnosticsSema.def

@@ -4521,6 +4521,9 @@ WARNING(property_wrapper_init_initialValue,none,
         ())
 ERROR(property_wrapper_projection_value_missing,none,
       "could not find projection value property %0", (Identifier))
+ERROR(property_wrapper_missing_arg_init, none, "missing argument for parameter "
+      "%0 in property wrapper initializer; add 'wrappedValue' and %0 "
+      "arguments in '@%1(...)'", (Identifier, StringRef))
 
 //------------------------------------------------------------------------------
 // MARK: function builder diagnostics

lib/Sema/CSDiag.cpp

@@ -3241,13 +3241,8 @@ class ArgumentMatcher : public MatchCallArgumentListener {
     SmallString<32> insertBuf;
     llvm::raw_svector_ostream insertText(insertBuf);
 
-    if (argIdx != 0) {
-      if (isPropertyWrapperImplicitInit()) {
-        insertText << "(";
-      } else {
-        insertText << ", ";
-      }
-    }
+    if (argIdx != 0)
+      insertText << ", ";
     if (!name.empty())
       insertText << name.str() << ": ";
     Type Ty = param.getOldType();
@@ -3262,9 +3257,6 @@ class ArgumentMatcher : public MatchCallArgumentListener {
     insertText << "<#" << Ty << "#>";
     if (argIdx == 0 && insertableEndIdx != 0)
       insertText << ", ";
-    if (isPropertyWrapperImplicitInit()) {
-      insertText << ")";
-    }
 
     SourceLoc insertLoc;
     if (argIdx > insertableEndIdx) {
@@ -3275,9 +3267,6 @@ class ArgumentMatcher : public MatchCallArgumentListener {
       //   fn(x: 1) { return 1 }
       // is diagnosed as "missing argument for 'y'" (missingParamIdx 1).
       // It should be "missing argument for 'z'" (missingParamIdx 2).
-    } else if (isPropertyWrapperImplicitInit()) {
-      insertLoc =
-          Lexer::getLocForEndOfToken(TC.Context.SourceMgr, FnExpr->getLoc());
     } else if (auto *TE = dyn_cast<TupleExpr>(ArgExpr)) {
       // fn():
       //   fn([argMissing])
@@ -3340,13 +3329,20 @@ class ArgumentMatcher : public MatchCallArgumentListener {
 
     assert(insertLoc.isValid() && "missing argument after trailing closure?");
 
-    if (name.empty())
+    if (name.empty()) {
       TC.diagnose(insertLoc, diag::missing_argument_positional,
                   missingParamIdx + 1)
           .fixItInsert(insertLoc, insertText.str());
-    else
-      TC.diagnose(insertLoc, diag::missing_argument_named, name)
-          .fixItInsert(insertLoc, insertText.str());
+    } else {
+      if (isPropertyWrapperImplicitInit()) {
+        auto TE = cast<TypeExpr>(FnExpr);
+        TC.diagnose(TE->getLoc(), diag::property_wrapper_missing_arg_init, name,
+                    TE->getInstanceType()->getString());
+      } else {
+        TC.diagnose(insertLoc, diag::missing_argument_named, name)
+            .fixItInsert(insertLoc, insertText.str());
+      }
+    }
 
     auto candidate = CandidateInfo[0];
     if (candidate.getDecl())

test/decl/var/property_wrappers.swift

@@ -1095,7 +1095,7 @@ struct InvalidPropertyDelegateUse {
 // SR-11060
 
 class SR_11060_Class {
-  @SR_11060_Wrapper var property: Int = 1234 // expected-error {{missing argument for parameter 'string' in call}}{{20-20=(string: <#String#>)}}
+  @SR_11060_Wrapper var property: Int = 1234 // expected-error {{missing argument for parameter 'string' in property wrapper initializer; add 'wrappedValue' and 'string' arguments in '@SR_11060_Wrapper(...)'}}
 }
 
 @propertyWrapper
@@ -1106,3 +1106,4 @@ struct SR_11060_Wrapper {
     self.wrappedValue = wrappedValue
   }
 }
+