[Diagnostics] Adjust RemoveUnnecessaryCoercion and UnnecessaryCoercionFailure to use solution on diagnose()

Author: LucianoPAlmeida

lib/Sema/CSDiagnostics.h

@@ -1804,10 +1804,10 @@ class UnnecessaryCoercionFailure final
     : public ContextualFailure {
 
 public:
-  UnnecessaryCoercionFailure(ConstraintSystem &cs,
+  UnnecessaryCoercionFailure(const Solution &solution,
                              Type fromType, Type toType,
                              ConstraintLocator *locator)
-      : ContextualFailure(cs, fromType, toType, locator) {}
+      : ContextualFailure(solution, fromType, toType, locator) {}
 
   bool diagnoseAsError() override;
 };

lib/Sema/CSFix.cpp

@@ -1136,9 +1136,8 @@ IgnoreContextualType *IgnoreContextualType::create(ConstraintSystem &cs,
       IgnoreContextualType(cs, resultTy, specifiedTy, locator);
 }
 
-bool RemoveUnnecessaryCoercion::diagnose(bool asNote) const {
-  auto &cs = getConstraintSystem();
-  UnnecessaryCoercionFailure failure(cs, getFromType(), getToType(),
+bool RemoveUnnecessaryCoercion::diagnose(const Solution &solution, bool asNote) const {
+  UnnecessaryCoercionFailure failure(solution, getFromType(), getToType(),
                                      getLocator());
   return failure.diagnose(asNote);
 }

lib/Sema/CSFix.h

@@ -1577,7 +1577,7 @@ class RemoveUnnecessaryCoercion : public ContextualMismatch {
     return "remove unnecessary explicit type coercion";
   }
 
-  bool diagnose(bool asNote = false) const override;
+  bool diagnose(const Solution &solution, bool asNote = false) const override;
 
   static bool attempt(ConstraintSystem &cs, Type fromType, Type toType,
                       ConstraintLocatorBuilder locator);