IRGen: Don't treat private visibility like internal

Author: slavapestov

lib/SIL/SIL.cpp

@@ -57,9 +57,7 @@ FormalLinkage swift::getDeclLinkage(const ValueDecl *D) {
     return FormalLinkage::HiddenUnique;
   case AccessLevel::FilePrivate:
   case AccessLevel::Private:
-    // Why "hidden" instead of "private"? Because the debugger may need to
-    // access these symbols.
-    return FormalLinkage::HiddenUnique;
+    return FormalLinkage::Private;
   }
 
   llvm_unreachable("Unhandled access level in switch.");

test/IRGen/access_control.sil

@@ -12,16 +12,16 @@ internal struct InternalStruct { var x: Int }
 // CHECK: @"$S14access_control14InternalStructVMf" = internal constant
 
 private struct PrivateStruct { var x: Int }
-// CHECK: @"$S14access_control13PrivateStruct33_8F630B0A1EEF3ED34B761E3ED76C95A8LLVMn" = hidden constant
+// CHECK: @"$S14access_control13PrivateStruct33_8F630B0A1EEF3ED34B761E3ED76C95A8LLVMn" = internal constant
 // CHECK: @"$S14access_control13PrivateStruct33_8F630B0A1EEF3ED34B761E3ED76C95A8LLVMf" = internal constant
 
 func local() {
   struct LocalStruct { var x: Int }
-  // CHECK: @"$S14access_control5localyyF11LocalStructL_VMn" = hidden constant
+  // CHECK: @"$S14access_control5localyyF11LocalStructL_VMn" = internal constant
   // CHECK: @"$S14access_control5localyyF11LocalStructL_VMf" = internal constant
 }
 
 // CHECK: @"$S14access_control12PublicStructVN" = {{(protected )?}}alias
 // CHECK: @"$S14access_control14InternalStructVN" = hidden alias
-// CHECK: @"$S14access_control13PrivateStruct33_8F630B0A1EEF3ED34B761E3ED76C95A8LLVN" = hidden alias
-// CHECK: @"$S14access_control5localyyF11LocalStructL_VN" = hidden alias
+// CHECK: @"$S14access_control13PrivateStruct33_8F630B0A1EEF3ED34B761E3ED76C95A8LLVN" = internal alias
+// CHECK: @"$S14access_control5localyyF11LocalStructL_VN" = internal alias

test/IRGen/decls.swift

@@ -20,6 +20,6 @@ func test1() {
 }
 
 // Check that we emit nominal type descriptors for all types.
-// CHECK-DAG: @"$S5decls5test1yyF1aL_CMn" = hidden constant
-// CHECK-DAG: @"$S5decls5test1yyF1bL_CMn" = hidden constant
+// CHECK-DAG: @"$S5decls5test1yyF1aL_CMn" = internal constant
+// CHECK-DAG: @"$S5decls5test1yyF1bL_CMn" = internal constant
 

test/IRGen/local_types.swift

@@ -50,7 +50,7 @@ public func topLevelIfConfig() {
 }
 #else
 public func topLevelIfConfig() {
-  // CHECK-DAG: @"$S11local_types16topLevelIfConfigyyF17LocalClassEnabledL_CMm" = hidden global %objc_class
+  // CHECK-DAG: @"$S11local_types16topLevelIfConfigyyF17LocalClassEnabledL_CMm" = internal global %objc_class
   class LocalClassEnabled {}
 }
 #endif
@@ -62,7 +62,7 @@ public struct NominalIfConfig {
   }
   #else
   public func method() {
-    // CHECK-DAG: @"$S11local_types15NominalIfConfigV6methodyyF17LocalClassEnabledL_CMm" = hidden global %objc_class
+    // CHECK-DAG: @"$S11local_types15NominalIfConfigV6methodyyF17LocalClassEnabledL_CMm" = internal global %objc_class
     class LocalClassEnabled {}
   }
   #endif
@@ -75,10 +75,10 @@ public func innerIfConfig() {
     class LocalClassDisabled {}
   }
   #else
-  // CHECK-DAG: @"$S11local_types13innerIfConfigyyF17LocalClassEnabledL_CMm" = hidden global %objc_class
+  // CHECK-DAG: @"$S11local_types13innerIfConfigyyF17LocalClassEnabledL_CMm" = internal global %objc_class
   class LocalClassEnabled {}
   func inner() {
-    // CHECK-DAG: @"$S11local_types13innerIfConfigyyF0C0L0_yyF17LocalClassEnabledL_CMm" = hidden global %objc_class
+    // CHECK-DAG: @"$S11local_types13innerIfConfigyyF0C0L0_yyF17LocalClassEnabledL_CMm" = internal global %objc_class
     class LocalClassEnabled {}
   }
   #endif

test/IRGen/nested_private_type_context_descriptor.swift

@@ -1,7 +1,7 @@
 // RUN: %target-swift-frontend -emit-ir -O -wmo %s | %FileCheck %s
 
-// CHECK-DAG: @"$S38nested_private_type_context_descriptor1X33{{.................................}}LLVMn" = hidden constant
-// CHECK-DAG: @"$S38nested_private_type_context_descriptor1X33{{.................................}}LLV1YVMn" = hidden constant
+// CHECK-DAG: @"$S38nested_private_type_context_descriptor1X33{{.................................}}LLVMn" = internal constant
+// CHECK-DAG: @"$S38nested_private_type_context_descriptor1X33{{.................................}}LLV1YVMn" = internal constant
 
 fileprivate struct X {
   fileprivate struct Y {}