Skip to content

Commit f90a7f0

Browse files
authored
Merge pull request #7931 from apple/revert-7860-build_script_impl_linux_benchmarks
Revert "[build-script-impl] Add support for building benchmarks on linux but disable it in all currently defined presets for linux."
2 parents e818400 + da4d084 commit f90a7f0

File tree

3 files changed

+0
-76
lines changed

3 files changed

+0
-76
lines changed

utils/build-presets.ini

Lines changed: 0 additions & 69 deletions
Original file line numberDiff line numberDiff line change
@@ -549,53 +549,6 @@ swift-primary-variant-arch=x86_64
549549
# Don't build the benchmarks
550550
skip-build-benchmarks
551551

552-
[preset: buildbot_incremental,tools=RA,stdlib=RD,smoketest=macosx,benchmarks]
553-
mixin-preset=buildbot_incremental_base
554-
build-subdir=buildbot_incremental
555-
556-
# We build release+asserts.
557-
release
558-
assertions
559-
560-
# We run the OS X tests and validation tests.
561-
test
562-
validation-test
563-
564-
llvm-targets-to-build=X86
565-
566-
# Set the vendor to apple
567-
compiler-vendor=apple
568-
569-
dash-dash
570-
571-
# Always reconfigure cmake
572-
reconfigure
573-
574-
# We want to always perform a verbose build
575-
verbose-build
576-
577-
# Build ninja while we are at it
578-
build-ninja
579-
580-
# We need to build the unittest extras so we can test
581-
build-swift-stdlib-unittest-extra
582-
583-
# Make sure our stdlib is RA.
584-
swift-stdlib-build-type=RelWithDebInfo
585-
swift-stdlib-enable-assertions=true
586-
587-
# Disable non-x86 building/testing.
588-
skip-build-ios
589-
skip-test-ios
590-
skip-build-tvos
591-
skip-test-tvos
592-
skip-build-watchos
593-
skip-test-watchos
594-
stdlib-deployment-targets=macosx-x86_64
595-
swift-primary-variant-sdk=OSX
596-
swift-primary-variant-arch=x86_64
597-
598-
599552
[preset: buildbot_incremental,tools=RA,stdlib=RD,smoketest=macosx,flto]
600553
mixin-preset=buildbot_incremental,tools=RA,stdlib=RD,smoketest=macosx
601554
build-subdir=buildbot_incremental
@@ -784,25 +737,6 @@ lit-args=-v
784737

785738
dash-dash
786739

787-
install-foundation
788-
install-libdispatch
789-
reconfigure
790-
skip-build-benchmarks
791-
792-
[preset: buildbot_linux,build_benchmark]
793-
mixin-preset=mixin_linux_installation
794-
build-subdir=buildbot_linux
795-
lldb
796-
release
797-
test
798-
validation-test
799-
long-test
800-
foundation
801-
libdispatch
802-
lit-args=-v
803-
804-
dash-dash
805-
806740
install-foundation
807741
install-libdispatch
808742
reconfigure
@@ -840,8 +774,6 @@ install-foundation
840774
install-libdispatch
841775
reconfigure
842776
skip-test-lldb
843-
skip-build-benchmarks
844-
845777

846778

847779
[preset: buildbot_linux_1404_no_lldb]
@@ -903,7 +835,6 @@ dash-dash
903835

904836
build-ninja
905837
reconfigure
906-
skip-build-benchmarks
907838

908839
[preset: buildbot_incremental_linux]
909840
mixin-preset=buildbot_incremental_linux_base

utils/build-script-impl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1326,8 +1326,6 @@ function calculate_targets_for_host() {
13261326
swift_sdk="LINUX"
13271327
build_for_this_target=$(not ${SKIP_BUILD_LINUX})
13281328
test_this_target=$(not ${SKIP_TEST_LINUX})
1329-
build_benchmark_this_target=$(not ${SKIP_BUILD_LINUX})
1330-
test_benchmark_this_target=$(not ${SKIP_BUILD_LINUX})
13311329
;;
13321330
freebsd-*)
13331331
swift_sdk="FREEBSD"

utils/swift_build_support/swift_build_support/targets.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -119,11 +119,6 @@ class StdlibDeploymentTarget(object):
119119
"powerpc64",
120120
"powerpc64le",
121121
"s390x"])
122-
# We support build/test benchmarks only on Linux x86_64.
123-
#
124-
# TODO: If we support any more platforms, we should consider refactoring the
125-
# supports_benchmark property onto the target from the platform.
126-
Linux.x86_64.supports_benchmark = True
127122

128123
FreeBSD = Platform("freebsd", archs=["x86_64"])
129124

0 commit comments

Comments
 (0)