Merge pull request #21705 from slavapestov/bogus-request-layout

Sema: Remove bogus call to requestNominalLayout()

Author: slavapestov

lib/Sema/CSApply.cpp

@@ -7401,11 +7401,6 @@ Expr *ExprRewriter::finishApply(ApplyExpr *apply, Type openedType,
     cs.setType(apply, fnType->getResult());
     apply->setIsSuper(isSuper);
 
-    // We need the layout of nominal types returned from a function call.
-    if (auto nominalResult = fnType->getResult()->getAnyNominal()) {
-      tc.requestNominalLayout(nominalResult);
-    }
-
     cs.setExprTypes(apply);
     Expr *result = tc.substituteInputSugarTypeForResult(apply);
     cs.cacheExprTypes(result);

test/multifile/require-layout-call-result.swift

@@ -1,8 +1,8 @@
-// RUN: %target-typecheck-verify-swift -module-name test -primary-file %S/Inputs/require-layout-call-result-primary.swift
+// RUN: %target-swift-frontend -emit-ir -module-name test %s -primary-file %S/Inputs/require-layout-call-result-primary.swift
 
 
 class C<T> {
-  dynamic func broken() { } // expected-error{{'dynamic'}}
+  func broken() { }
 }
 
 func bar<T, U: C<T>>(_ t: T, _ u: U) -> C<T> { return u }