Skip to content

Commit fd0012e

Browse files
authored
Merge pull request #34501 from DougGregor/concurrency-auto-import-fix
[Concurrency] Only auto-import _Concurrency when auto-importing Swift.
2 parents 2818294 + e078337 commit fd0012e

File tree

33 files changed

+42
-1
lines changed

33 files changed

+42
-1
lines changed

lib/Frontend/Frontend.cpp

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -763,7 +763,15 @@ ImplicitImportInfo CompilerInstance::getImplicitImportInfo() const {
763763
}
764764

765765
if (Invocation.shouldImportSwiftConcurrency()) {
766-
pushImport(SWIFT_CONCURRENCY_NAME);
766+
switch (imports.StdlibKind) {
767+
case ImplicitStdlibKind::Builtin:
768+
case ImplicitStdlibKind::None:
769+
break;
770+
771+
case ImplicitStdlibKind::Stdlib:
772+
pushImport(SWIFT_CONCURRENCY_NAME);
773+
break;
774+
}
767775
}
768776

769777
imports.ShouldImportUnderlyingModule = frontendOpts.ImportUnderlyingModule;

test/IRGen/async/run-call-classinstance-int64-to-void.sil

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import Builtin
1616
import Swift
1717
import PrintShims
18+
import _Concurrency
1819

1920
sil public_external @printAny : $@convention(thin) (@in_guaranteed Any) -> ()
2021

test/IRGen/async/run-call-classinstance-void-to-void.sil

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import Builtin
1616
import Swift
1717
import PrintShims
18+
import _Concurrency
1819

1920
sil public_external @printAny : $@convention(thin) (@in_guaranteed Any) -> ()
2021

test/IRGen/async/run-call-existential-to-void.sil

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import Builtin
1616
import Swift
1717
import PrintShims
18+
import _Concurrency
1819

1920
sil public_external @printAny : $@convention(thin) (@in_guaranteed Any) -> ()
2021

test/IRGen/async/run-call-generic-to-generic.sil

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import Builtin
1616
import Swift
1717
import PrintShims
18+
import _Concurrency
1819

1920
sil public_external @printInt64 : $@convention(thin) (Int64) -> ()
2021

test/IRGen/async/run-call-generic-to-void.sil

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import Builtin
1616
import Swift
1717
import PrintShims
18+
import _Concurrency
1819

1920
sil public_external @printGeneric : $@convention(thin) <T> (@in_guaranteed T) -> ()
2021

test/IRGen/async/run-call-genericEquatable-x2-to-bool.sil

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import Builtin
1616
import Swift
1717
import PrintShims
18+
import _Concurrency
1819

1920
sil public_external @printBool : $@convention(thin) (Bool) -> ()
2021

test/IRGen/async/run-call-int64-and-int64-to-void.sil

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import Builtin
1616
import Swift
1717
import PrintShims
18+
import _Concurrency
1819

1920
sil public_external @printInt64 : $@convention(thin) (Int64) -> ()
2021

test/IRGen/async/run-call-int64-to-void.sil

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import Builtin
1616
import Swift
1717
import PrintShims
18+
import _Concurrency
1819

1920
sil public_external @printInt64 : $@convention(thin) (Int64) -> ()
2021

test/IRGen/async/run-call-protocolextension_instance-void-to-int64.sil

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import Builtin
1515
import Swift
1616
import PrintShims
17+
import _Concurrency
1718

1819
sil public_external @printGeneric : $@convention(thin) <T> (@in_guaranteed T) -> ()
1920
sil public_external @printInt64 : $@convention(thin) (Int64) -> ()

test/IRGen/async/run-call-protocolwitness_instance-void-to-int64.sil

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import Builtin
1515
import Swift
1616
import PrintShims
17+
import _Concurrency
1718

1819
sil public_external @printGeneric : $@convention(thin) <T> (@in_guaranteed T) -> ()
1920
sil public_external @printInt64 : $@convention(thin) (Int64) -> ()

test/IRGen/async/run-call-structinstance-int64-to-void.sil

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import Builtin
1515
import Swift
1616
import PrintShims
17+
import _Concurrency
1718

1819
sil public_external @printInt64 : $@convention(thin) (Int64) -> ()
1920
sil public_external @printGeneric : $@convention(thin) <T> (@in_guaranteed T) -> ()

test/IRGen/async/run-call-void-throws-to-int-throwing.sil

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import Builtin
1616
import Swift
1717
import PrintShims
18+
import _Concurrency
1819

1920
sil public_external @printInt64 : $@convention(thin) (Int64) -> ()
2021

test/IRGen/async/run-call-void-throws-to-int-throwing_call-async-nothrow_call-sync-throw.sil

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import Builtin
1515
import Swift
1616
import PrintShims
17+
import _Concurrency
1718

1819
sil public_external @printInt64 : $@convention(thin) (Int64) -> ()
1920

test/IRGen/async/run-call-void-throws-to-int-throwing_call-async-throw.sil

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import Builtin
1616
import Swift
1717
import PrintShims
18+
import _Concurrency
1819

1920
sil public_external @printInt64 : $@convention(thin) (Int64) -> ()
2021

test/IRGen/async/run-call-void-throws-to-int-throwing_call-sync-nothrow_call-async-throw.sil

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import Builtin
1616
import Swift
1717
import PrintShims
18+
import _Concurrency
1819

1920
sil public_external @printInt64 : $@convention(thin) (Int64) -> ()
2021

test/IRGen/async/run-call-void-throws-to-int-throwing_call-sync-throw.sil

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
import Builtin
1616
import Swift
1717
import PrintShims
18+
import _Concurrency
19+
1820

1921
sil public_external @printInt64 : $@convention(thin) (Int64) -> ()
2022

test/IRGen/async/run-call-void-to-existential.sil

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import Builtin
1616
import Swift
1717
import PrintShims
18+
import _Concurrency
1819

1920
sil public_external @printAny : $@convention(thin) (@in_guaranteed Any) -> ()
2021

test/IRGen/async/run-call-void-to-int64-and-int64.sil

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import Builtin
1616
import Swift
1717
import PrintShims
18+
import _Concurrency
1819

1920
sil public_external @printInt64 : $@convention(thin) (Int64) -> ()
2021

test/IRGen/async/run-call-void-to-int64.sil

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import Builtin
1616
import Swift
1717
import PrintShims
18+
import _Concurrency
1819

1920
sil public_external @printInt64 : $@convention(thin) (Int64) -> ()
2021

test/IRGen/async/run-call-void-to-struct_large.sil

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import Builtin
1515
import Swift
1616
import PrintShims
17+
import _Concurrency
1718

1819
sil public_external @printGeneric : $@convention(thin) <T> (@in_guaranteed T) -> ()
1920

test/IRGen/async/run-call_generic-protocolwitness_instance-generic-to-int64-and-generic.sil

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import Builtin
1515
import Swift
1616
import PrintShims
17+
import _Concurrency
1718

1819
sil public_external @printGeneric : $@convention(thin) <T> (@in_guaranteed T) -> ()
1920
sil public_external @printInt64 : $@convention(thin) (Int64) -> ()

test/IRGen/async/run-call_generic-protocolwitness_instance-void-to-int64.sil

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import Builtin
1515
import Swift
1616
import PrintShims
17+
import _Concurrency
1718

1819
sil public_external @printGeneric : $@convention(thin) <T> (@in_guaranteed T) -> ()
1920
sil public_external @printInt64 : $@convention(thin) (Int64) -> ()

test/IRGen/async/run-partialapply-capture-class-to-void.sil

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import Builtin
1515
import Swift
1616
import PrintShims
17+
import _Concurrency
1718

1819
sil public_external @printGeneric : $@convention(thin) <T> (@in_guaranteed T) -> ()
1920

test/IRGen/async/run-partialapply-capture-generic_conformer-and-generic-to-void.sil

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import Builtin
1515
import Swift
1616
import PrintShims
17+
import _Concurrency
1718

1819
sil public_external @printGeneric : $@convention(thin) <T> (@in_guaranteed T) -> ()
1920
sil public_external @printInt64 : $@convention(thin) (Int64) -> ()

test/IRGen/async/run-partialapply-capture-inout-generic-and-in-generic-to-generic.sil

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import Builtin
1515
import Swift
1616
import PrintShims
17+
import _Concurrency
1718

1819
sil public_external @printGeneric : $@convention(thin) <T> (@in_guaranteed T) -> ()
1920
sil public_external @printInt64 : $@convention(thin) (Int64) -> ()

test/IRGen/async/run-partialapply-capture-int64-int64-to-int64.sil

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import Builtin
1515
import Swift
1616
import PrintShims
17+
import _Concurrency
1718

1819
sil public_external @printGeneric : $@convention(thin) <T> (@in_guaranteed T) -> ()
1920
sil public_external @printInt64 : $@convention(thin) (Int64) -> ()

test/IRGen/async/run-partialapply-capture-int64-to-generic.sil

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import Builtin
1515
import Swift
1616
import PrintShims
17+
import _Concurrency
1718

1819
sil public_external @printGeneric : $@convention(thin) <T> (@in_guaranteed T) -> ()
1920
sil public_external @printInt32 : $@convention(thin) (Int32) -> ()

test/IRGen/async/run-partialapply-capture-struct_classinstance_classinstance-and-int64-to-int64.sil

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import Builtin
1515
import Swift
1616
import PrintShims
17+
import _Concurrency
1718

1819
sil public_external @printGeneric : $@convention(thin) <T> (@in_guaranteed T) -> ()
1920
sil public_external @printInt64 : $@convention(thin) (Int64) -> ()

test/IRGen/async/run-partialapply-capture-structgeneric_classinstance_to_struct_and_error.sil

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import Builtin
1515
import Swift
1616
import PrintShims
17+
import _Concurrency
1718

1819
sil public_external @printGeneric : $@convention(thin) <T> (@in_guaranteed T) -> ()
1920

test/IRGen/async/run-partialapply-capture-structgeneric_polymorphic_constrained-to-void.sil

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import Builtin
1515
import Swift
1616
import PrintShims
17+
import _Concurrency
1718

1819
sil public_external @printGeneric : $@convention(thin) <T> (@in_guaranteed T) -> ()
1920

test/IRGen/async/run-partialapply-capture-type_structgeneric_polymorphic_constrained-to-void.sil

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import Builtin
1515
import Swift
1616
import PrintShims
17+
import _Concurrency
1718

1819
sil public_external @printGeneric : $@convention(thin) <T> (@in_guaranteed T) -> ()
1920

test/IRGen/async/run-partialapply-capture-type_thin-and-classinstance-to-void.sil

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import Builtin
1515
import Swift
1616
import PrintShims
17+
import _Concurrency
1718

1819
sil public_external @printGeneric : $@convention(thin) <T> (@in_guaranteed T) -> ()
1920
sil public_external @printInt64 : $@convention(thin) (Int64) -> ()

0 commit comments

Comments
 (0)